Modify nhr_obsbin logic in exglobal_atmos_analysis.sh to address NCO bugzilla #1123
Description
Expected behavior
gsi.x error messages for missing high resolution background files should include the name of the missing file.
Current behavior
NCO GFS v16.3.3 testing found that while gsi.x flagged a missing file it did not identify which file was missing. NCO bugzilla #1196 was updated accordingly with a request that gsi.x error messages be improved.
Machines affected
Behavior observed by NCO during GFS v16.3.3 testing on WCOSS2.
Detailed Description
Examination of gsi source code file read_files.f90 shows that the code performed as expected. The issue uncovered by NCO's testing points to an inconsistency in exglobal_atmos_analysis.sh. The logical test used to set gsi namelist variable nhr_obsbin is not consistent with other checks in the script which use variable l4densvar.
The logical test to set nhr_obsbin was modified to be consistent with other tests using l4densvar. The updated script was tested with gdas.t12z.atmf005.nc missing for an 18Z analysis. gsi.x aborted as it should
0: READ_FILES: ***FATAL ERROR*** insufficient atm fcst for 4densvar: PROGRAM STOPS
0: READ_FILES: ***FATAL ERROR*** file sigf05 missing: PROGRAM STOPS
48: application called MPI_Abort(MPI_COMM_WORLD, 99) - process 48
The error message includes the name of the missing background file.
Possible Implementation
The proposed change to exglobal_atmos_analysis.sh is in forked branch RussTreadon-NOAA/global-workflow:feature/anl_errmsg.