Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCPP: Update consistency checks and effective radii calculation for Thompson MP #462

Merged
merged 32 commits into from
Jan 20, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
984c430
Add additional diagnostic arrays for radiation-microphysics development
climbfuji Nov 19, 2021
6c961cc
Bug fixes for WAM model runs with levr < levs
climbfuji Nov 23, 2021
d3ab491
Update submodule pointer for ccpp-physocs
climbfuji Nov 23, 2021
086f326
Update .gitmodules and submodule pointer for ccpp-physics for code re…
climbfuji Nov 23, 2021
cad85e6
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
climbfuji Nov 29, 2021
4cb7110
Update submodule pointer for ccpp-physics
climbfuji Nov 29, 2021
edce3d6
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
climbfuji Dec 6, 2021
6bc920d
Update .gitmodules and submodule pointer for ccpp-physics for code re…
climbfuji Dec 6, 2021
5da45f5
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/fv3at…
climbfuji Dec 6, 2021
6163991
Change output names of new radiation diagnostic variables in ccpp/dri…
climbfuji Dec 6, 2021
8d5a15a
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/fv3at…
climbfuji Dec 6, 2021
7165cd0
Update submodule pointer for ccpp-physics
climbfuji Dec 7, 2021
e709caf
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
climbfuji Dec 9, 2021
fbd7b52
Update submodule pointer for ccpp-physics
climbfuji Dec 9, 2021
c033555
Update submodule pointer for ccpp-physics
climbfuji Dec 10, 2021
8e4866b
Fix ccpp-physics branch name in .gitmodules
climbfuji Dec 10, 2021
4e5639f
Fix .gitmodules one more time
climbfuji Dec 10, 2021
b10942f
Update submodule pointer for ccpp-physics
climbfuji Dec 10, 2021
f34aa31
Merge branch 'rad_mp_diag_vars' of https://github.com/climbfuji/fv3at…
climbfuji Dec 10, 2021
2fa9b76
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
climbfuji Dec 22, 2021
e961f38
Update submodule pointer for ccpp-physics
climbfuji Dec 22, 2021
33d41af
Update submodule pointer for ccpp-physics
climbfuji Dec 22, 2021
af11409
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
climbfuji Dec 29, 2021
c53d983
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into wam…
climbfuji Dec 30, 2021
0a8ab77
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into wam…
climbfuji Jan 3, 2022
35d25f5
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into wam…
climbfuji Jan 6, 2022
cdee27a
Enable outputting cloud effective radii from ccpp/driver/GFS_diagnost…
climbfuji Jan 9, 2022
20a7d53
Update submodule pointer for ccpp-physics
climbfuji Jan 9, 2022
fc7dcc1
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into tho…
climbfuji Jan 9, 2022
bd3b93d
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into tho…
climbfuji Jan 17, 2022
f20ca51
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into tho…
climbfuji Jan 19, 2022
2ca1627
Revert change to .gitmodules and update submodule pointer for ccpp-ph…
climbfuji Jan 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into rad…
…_mp_diag_vars
  • Loading branch information
climbfuji committed Nov 29, 2021
commit cad85e663a1c47357bbf3f9a5a4143f673b71942
4 changes: 4 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@
#branch = main
url = https://github.com/gthompsnWRF/ccpp-physics
branch = new_thompson_cloud_fraction
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
branch = develop
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ add_subdirectory(atmos_cubed_sphere)
### fv3atm
###############################################################################
if(INLINE_POST)
set(BUILD_POSTEXEC OFF)
add_subdirectory(upp)
set(POST_SRC io/inline_post.F90 io/post_nems_routines.F90 io/post_gfs.F90 io/post_regional.F90)
else()
set(POST_SRC io/inline_post_stub.F90)
Expand Down
2 changes: 1 addition & 1 deletion ccpp/data/CCPP_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
[pkz]
standard_name = finite_volume_mean_edge_pressure_raised_to_the_power_of_kappa
long_name = finite-volume mean edge pressure raised to the power of kappa
units = Pa**kappa
units = 1
dimensions = (starting_x_direction_index:ending_x_direction_index,starting_y_direction_index:ending_y_direction_index,1:vertical_dimension_for_fast_physics)
type = real
kind = kind_dyn
Expand Down
17 changes: 6 additions & 11 deletions ccpp/data/GFS_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -823,8 +823,7 @@ module GFS_typedefs
integer :: thompson_ext_ndiag3d=37 !< number of 3d arrays for extended diagnostic output from Thompson
real(kind=kind_phys) :: dt_inner !< time step for the inner loop in s
logical :: sedi_semi !< flag for semi Lagrangian sedi of rain
logical :: sedi_semi_update!< flag for v update in semi Lagrangian sedi of rain
logical :: sedi_semi_decfl !< flag for interation with semi Lagrangian sedi of rain
integer :: decfl !< deformed CFL factor

!--- GFDL microphysical paramters
logical :: lgfdlmprad !< flag for GFDL mp scheme and radiation consistency
Expand Down Expand Up @@ -3199,8 +3198,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
logical :: ext_diag_thompson = .false. !< flag for extended diagnostic output from Thompson
real(kind=kind_phys) :: dt_inner = -999.0 !< time step for the inner loop
logical :: sedi_semi = .false. !< flag for semi Lagrangian sedi of rain
logical :: sedi_semi_update = .false. !< flag for v update in semi Lagrangian sedi of rain
logical :: sedi_semi_decfl = .false. !< flag for interation with semi Lagrangian sedi of rain
integer :: decfl = 8 !< deformed CFL factor

!--- GFDL microphysical parameters
logical :: lgfdlmprad = .false. !< flag for GFDLMP radiation interaction
Expand Down Expand Up @@ -3570,7 +3568,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
mg_alf, mg_qcmin, mg_do_ice_gmao, mg_do_liq_liu, &
ltaerosol, lradar, nsradar_reset, lrefres, ttendlim, &
ext_diag_thompson, dt_inner, lgfdlmprad, &
sedi_semi, sedi_semi_update, sedi_semi_decfl, &
sedi_semi, decfl, &
!--- max hourly
avg_max_length, &
!--- land/surface model control
Expand Down Expand Up @@ -4046,8 +4044,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
Model%dt_inner = Model%dtp
endif
Model%sedi_semi = sedi_semi
Model%sedi_semi_update = sedi_semi_update
Model%sedi_semi_decfl = sedi_semi_decfl
Model%decfl = decfl
!--- F-A MP parameters
Model%rhgrd = rhgrd
Model%spec_adv = spec_adv
Expand Down Expand Up @@ -5124,8 +5121,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
' ext_diag_thompson =',Model%ext_diag_thompson, &
' dt_inner =',Model%dt_inner, &
' sedi_semi=',Model%sedi_semi, &
' sedi_semi_update=',sedi_semi_update, &
' sedi_semi_decfl=',sedi_semi_decfl, &
' decfl=',decfl, &
' effr_in =',Model%effr_in, &
' lradar =',Model%lradar, &
' nsradar_reset =',Model%nsradar_reset, &
Expand Down Expand Up @@ -5544,8 +5540,7 @@ subroutine control_print(Model)
print *, ' ext_diag_thompson : ', Model%ext_diag_thompson
print *, ' dt_inner : ', Model%dt_inner
print *, ' sedi_semi : ', Model%sedi_semi
print *, ' sedi_semi_update : ', Model%sedi_semi_update
print *, ' sedi_semi_decfl : ', Model%sedi_semi_decfl
print *, ' decfl : ', Model%decfl
print *, ' '
endif
if (Model%imp_physics == Model%imp_physics_mg) then
Expand Down
51 changes: 21 additions & 30 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
[hprime]
standard_name = statistical_measures_of_subgrid_orography_collection_array
long_name = orographic metrics
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_statistical_measures_of_subgrid_orography)
type = real
kind = kind_phys
Expand Down Expand Up @@ -3247,7 +3247,7 @@
[mg_qcvar]
standard_name = relative_variance_of_subgrid_cloud_condensate_distribution
long_name = cloud water relative variance for MG microphysics
units =
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand All @@ -3261,7 +3261,7 @@
[mg_rhmini]
standard_name = relative_humidity_threshold_for_ice_nucleation
long_name = relative humidity threshold parameter for nucleating ice for MG microphysics
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down Expand Up @@ -3512,21 +3512,12 @@
units = flag
dimensions = ()
type = logical
intent = in
[sedi_semi_update]
standard_name = flag_for_v_update_in_semi_Lagrangian_sedi
long_name = flag for v update in semi Lagrangian sedi of rain
units = flag
dimensions = ()
type = logical
intent = in
[sedi_semi_decfl]
standard_name = flag_for_iteration_with_semi_Lagrangian_sedi
long_name = flag for interation with semi Lagrangian sedi of rain
units = flag
[decfl]
standard_name = deformed_CFL_factor
long_name = deformed CFL factor
units = count
dimensions = ()
type = logical
intent = in
type = integer
[lgfdlmprad]
standard_name = flag_for_GFDL_microphysics_radiation_interaction
long_name = flag for GFDL microphysics-radiation interaction
Expand Down Expand Up @@ -3819,7 +3810,7 @@
[rhgrd]
standard_name = relative_humidity_threshold_for_condensation
long_name = relative humidity threshold parameter for condensation for FA scheme
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down Expand Up @@ -5735,21 +5726,21 @@
[tau_amf]
standard_name = absolute_momentum_flux_due_to_nonorographic_gravity_wave_drag
long_name = ngw_absolute_momentum_flux
units = various
units = mixed
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6340,7 +6331,7 @@
[fluxr]
standard_name = cumulative_radiation_diagnostic
long_name = time-accumulated 2D radiation-related diagnostic fields
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_diagnostics_variables_for_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6921,7 +6912,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6957,14 +6948,14 @@
[rh02max]
standard_name = maximum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = maximum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[rh02min]
standard_name = minimum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = minumum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
Expand Down Expand Up @@ -8228,7 +8219,7 @@
[faerlw]
standard_name = aerosol_optical_properties_for_longwave_bands_01_16
long_name = aerosol optical properties for longwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,adjusted_vertical_layer_dimension_for_radiation,number_of_aerosol_bands_for_longwave_radiation,number_of_aerosol_output_fields_for_longwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -8256,7 +8247,7 @@
[faersw]
standard_name = aerosol_optical_properties_for_shortwave_bands_01_16
long_name = aerosol optical properties for shortwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,adjusted_vertical_layer_dimension_for_radiation,number_of_aerosol_bands_for_shortwave_radiation,number_of_aerosol_output_fields_for_shortwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -9862,7 +9853,7 @@
[q_lay]
standard_name = water_vapor_mixing_ratio
long_name = water vaport mixing ratio
units = kg/kg
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
Expand Down Expand Up @@ -10024,7 +10015,7 @@
[aerosolslw]
standard_name = RRTMGP_aerosol_optical_properties_for_longwave_bands_01_16
long_name = aerosol optical properties for longwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension, number_of_longwave_bands,number_of_aerosol_output_fields_for_longwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -10053,7 +10044,7 @@
[aerosolssw]
standard_name = RRTMGP_aerosol_optical_properties_for_shortwave_bands_01_16
long_name = aerosol optical properties for shortwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension, number_of_shortwave_bands, number_of_aerosol_output_fields_for_shortwave_radiation)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion ccpp/framework
Submodule framework updated 79 files
+1 −0 .github/workflows/python.yaml
+3 −3 .travis.yml
+1 −1 CODEOWNERS
+6 −6 doc/HelloWorld/hello_scheme.meta
+2 −2 doc/HelloWorld/hello_world_host.meta
+6 −6 doc/HelloWorld/temp_adjust.meta
+84 −190 scripts/ccpp_capgen.py
+16 −101 scripts/ccpp_datafile.py
+9 −6 scripts/ccpp_fortran_to_metadata.py
+1 −1 scripts/ccpp_prebuild.py
+238 −1,997 scripts/ccpp_suite.py
+6 −2 scripts/code_block.py
+1 −1 scripts/common.py
+156 −72 scripts/constituents.py
+1 −1 scripts/conversion_tools/unit_conversion.py
+45 −34 scripts/ddt_library.py
+2 −2 scripts/file_utils.py
+13 −15 scripts/fortran_tools/fortran_write.py
+63 −28 scripts/fortran_tools/parse_fortran.py
+65 −66 scripts/fortran_tools/parse_fortran_file.py
+385 −0 scripts/framework_env.py
+41 −26 scripts/host_cap.py
+39 −31 scripts/host_model.py
+1 −1 scripts/metadata2html.py
+8 −2 scripts/metadata_parser.py
+73 −54 scripts/metadata_table.py
+252 −659 scripts/metavar.py
+1 −1 scripts/mkcap.py
+1 −1 scripts/mkdoc.py
+1 −1 scripts/mkstatic.py
+2 −0 scripts/parse_tools/__init__.py
+24 −12 scripts/parse_tools/parse_checkers.py
+1 −1 scripts/parse_tools/parse_log.py
+7 −2 scripts/parse_tools/parse_object.py
+6 −2 scripts/parse_tools/parse_source.py
+6 −2 scripts/parse_tools/preprocess.py
+123 −3 scripts/parse_tools/xml_tools.py
+8 −3 scripts/state_machine.py
+1,912 −0 scripts/suite_objects.py
+1,294 −0 scripts/var_props.py
+190 −164 src/ccpp_constituent_prop_mod.F90
+4 −4 test/advection_test/cld_ice.meta
+4 −4 test/advection_test/cld_liq.meta
+3 −3 test/advection_test/run_test
+5 −2 test/advection_test/test_host.F90
+9 −2 test/advection_test/test_host.meta
+1 −1 test/advection_test/test_host_data.meta
+8 −3 test/advection_test/test_reports.py
+6 −6 test/capgen_test/environ_conditions.meta
+6 −6 test/capgen_test/make_ddt.meta
+5 −5 test/capgen_test/run_test
+4 −2 test/capgen_test/temp_adjust.F90
+6 −6 test/capgen_test/temp_adjust.meta
+6 −6 test/capgen_test/temp_calc_adjust.meta
+8 −8 test/capgen_test/temp_set.meta
+7 −4 test/capgen_test/test_host.F90
+9 −2 test/capgen_test/test_host.meta
+1 −1 test/capgen_test/test_host_data.meta
+9 −4 test/capgen_test/test_reports.py
+6 −0 test/run_doctest.sh
+62 −0 test/run_tests.sh
+2 −2 test/unit_tests/sample_files/test_host.meta
+6 −6 test/unit_tests/sample_files/test_multi_ccpp_arg_tables.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_in_fort_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_missing_in_fort.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_missing_in_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPgt1_var_in_fort_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPnotset_var_missing_in_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/invalid_dummy_arg.meta
+2 −2 test/unit_tests/sample_scheme_files/invalid_subr_stmnt.meta
+6 −6 test/unit_tests/sample_scheme_files/mismatch_intent.meta
+4 −4 test/unit_tests/sample_scheme_files/missing_arg_table.meta
+6 −6 test/unit_tests/sample_scheme_files/missing_fort_header.meta
+6 −6 test/unit_tests/sample_scheme_files/reorder.meta
+6 −6 test/unit_tests/sample_scheme_files/temp_adjust.meta
+38 −31 test/unit_tests/test_metadata_scheme_file.py
+65 −68 test/unit_tests/test_metadata_table.py
+424 −0 test/unit_tests/test_var_transforms.py
+7 −3 tests/test_metadata_parser.py
2 changes: 1 addition & 1 deletion ccpp/physics
Submodule physics updated 45 files
+1 −1 CODEOWNERS
+1 −1 physics/GFS_DCNV_generic.meta
+3 −3 physics/GFS_GWD_generic.meta
+1 −1 physics/GFS_MP_generic.meta
+1 −1 physics/GFS_PBL_generic.meta
+1 −1 physics/GFS_SCNV_generic.meta
+5 −5 physics/GFS_phys_time_vary.fv3.meta
+5 −5 physics/GFS_phys_time_vary.scm.meta
+1 −1 physics/GFS_rrtmg_post.meta
+2 −2 physics/GFS_rrtmg_pre.F90
+1 −1 physics/GFS_rrtmgp_lw_post.meta
+1 −1 physics/GFS_rrtmgp_pre.meta
+1 −1 physics/GFS_rrtmgp_sw_post.meta
+1 −1 physics/GFS_rrtmgp_thompsonmp_pre.meta
+2 −2 physics/GFS_suite_interstitial.meta
+1 −1 physics/cires_ugwp.meta
+1 −1 physics/cu_gf_driver.meta
+1 −1 physics/drag_suite.meta
+2 −2 physics/gfdl_fv_sat_adj.meta
+1 −1 physics/gwdc.meta
+2 −2 physics/h2o_def.meta
+2 −2 physics/h2ophys.meta
+2 −2 physics/m_micro.meta
+2 −2 physics/maximum_hourly_diagnostics.meta
+1 −1 physics/module_MYJPBL_wrapper.meta
+1 −1 physics/module_MYNNPBL_wrapper.meta
+92 −61 physics/module_mp_thompson.F90
+1 −1 physics/moninedmf.meta
+1 −1 physics/moninshoc.meta
+1 −1 physics/mp_fer_hires.meta
+4 −8 physics/mp_thompson.F90
+5 −12 physics/mp_thompson.meta
+2 −2 physics/ozne_def.meta
+3 −3 physics/ozphys.meta
+3 −3 physics/ozphys_2015.meta
+1 −1 physics/phys_tend.meta
+51 −35 physics/radiation_clouds.f
+1 −1 physics/rayleigh_damp.meta
+1 −1 physics/satmedmfvdif.meta
+1 −1 physics/satmedmfvdifq.meta
+9 −9 physics/sfcsub.F
+1 −1 physics/shinhongvdif.meta
+2 −2 physics/ugwpv1_gsldrag.meta
+1 −1 physics/unified_ugwp.meta
+1 −1 physics/ysuvdif.meta
1 change: 1 addition & 0 deletions upp
Submodule upp added at c939ea
You are viewing a condensed version of this merge commit. You can view the full changes here.