Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMS-2023.02 release #684

Open
jkbk2004 opened this issue Aug 8, 2023 · 7 comments
Open

FMS-2023.02 release #684

jkbk2004 opened this issue Aug 8, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 8, 2023

Description

  1. Code changes are needed to update with the new version of FMS-2023.02. See the release notes here: https://github.com/NOAA-GFDL/FMS/releases/tag/2023.02
  2. Old fmsio has been deprecated and will only be compiled with the flag “use_deprecated_io”.
  3. A GFDL branch was created: https://github.com/laurenchilutti/GFDL_atmos_cubed_sphere/tree/deprecated_io_emc

Changes in the above feature branch:

  1. model/multi_gases.F90: optional read multi gas namelist
  2. minor update to use fms2_io_mod/file_exists, fms_io_mod/file_exist in tools/fv_iau_mod.F90 and fv_restart.F90
@jkbk2004 jkbk2004 added the enhancement New feature or request label Aug 8, 2023
@XiaqiongZhou-NOAA
Copy link
Contributor

XiaqiongZhou-NOAA commented Aug 8, 2023

@jkbk2004 : Lauren's GFDL dycore branch has the following two commits related to FMS 2023.02 release:

  1. remove deprecated fms function from multi_gases · laurenchilutti/GFDL_atmos_cubed_sphere@e0f6a20 (github.com)
  2. removing remaining old fms functions · laurenchilutti/GFDL_atmos_cubed_sphere@f83302b (github.com)

What do you mean about #4 about a new time scale Rayleigh damping et al? They are already in dev/emc dynamic core if you mean about the parameter "fast_tau_w_sec" ?

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Aug 8, 2023

@jkbk2004 : Lauren's GFDL dycore branch has the following two commits related to FMS 2023.02 release:

  1. remove deprecated fms function from multi_gases · laurenchilutti/GFDL_atmos_cubed_sphere@e0f6a20 (github.com)
  2. removing remaining old fms functions · laurenchilutti/GFDL_atmos_cubed_sphere@f83302b (github.com)

What do you mean about #4 about a new time scale Rayleigh damping et al? They are already in dev/emc dynamic core if you mean about the parameter "fast_tau_w_sec" ?

diff_fv_arrays

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Aug 8, 2023

@jkbk2004 : Lauren's GFDL dycore branch has the following two commits related to FMS 2023.02 release:

  1. remove deprecated fms function from multi_gases · laurenchilutti/GFDL_atmos_cubed_sphere@e0f6a20 (github.com)
  2. removing remaining old fms functions · laurenchilutti/GFDL_atmos_cubed_sphere@f83302b (github.com)

What do you mean about #4 about a new time scale Rayleigh damping et al? They are already in dev/emc dynamic core if you mean about the parameter "fast_tau_w_sec" ?

diff_fv_arrays

I just diff the difference of each routine at core level. So, are the parameters pretty much rearranged?

@XiaqiongZhou-NOAA
Copy link
Contributor

XiaqiongZhou-NOAA commented Aug 8, 2023

Which version of dev/emc are you using?
Check line 701 here:
https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/blob/dev/emc/model/fv_arrays.F90

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Aug 8, 2023

Which version of dev/emc are you using? Check line 701 here: https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/blob/dev/emc/model/fv_arrays.F90

Sorry! sounds like I am pointing to wrong hash. Let me re-write the issue.

@jkbk2004
Copy link
Collaborator Author

@laurenchilutti @XiaqiongZhou-NOAA one question about line 44 of molecular_diffusion.F90 in the deprecated_io_emc branch. It contains use fms_mod, only: check_nml_error, open_namelist_file, close_file. Does it need to clean up as multi_gases.F90 line 45 ?

@laurenchilutti
Copy link

@laurenchilutti @XiaqiongZhou-NOAA one question about line 44 of molecular_diffusion.F90 in the deprecated_io_emc branch. It contains use fms_mod, only: check_nml_error, open_namelist_file, close_file. Does it need to clean up as multi_gases.F90 line 45 ?

Yes, the same changes from multi_gases.F90 will need to be applied to any files that open namelist files with the open_namelist_file and close_file subroutines from fms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants