Add explicit interfaces for BACIO and g2 routines to remove Intel #8889 warnings #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR addresses Intel
warning #8889: Explicit declaration of the EXTERNAL attribute is requiredby adding explicit interface blocks for all NCEP libraries BACIO and GRIB2 (g2) routines used inww3_gribprogram. The warnings are successfully removed during debug build in both WW3 and operational workflows.Description
This PR adds explicit interface blocks for all NCEP BACIO and GRIB2 (g2) routines used in
ww3_grib.F90, eliminating Intel#8889warnings in debug builds and preventing potential runtime mismatches. Because the installed BACIO library does not export a module file,USE BACIO_MODULEcannot be applied; therefore, explicit interfaces are required for safe, type-checked calls toBAOPENW, WRYTE, GRIBCREATE, ADDGRID, ADDFIELD, and GRIBEND. The update ensures correct argument ranks and character declarations, removes the need forEXTERNAL, and preserves fully consistent behavior with NCEP library APIs.Issue(s) addressed
Addressing issue #1501
Commit Message
Add explicit interfaces for BACIO and g2 routines in ww3_grib.F90 to remove Intel #8889 warnings
Check list
Testing
Hercules Intel:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt
Hercules GNU:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt