Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RRFS control files #360

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Update RRFS control files #360

merged 2 commits into from
Aug 9, 2021

Conversation

WenMeng-NOAA
Copy link
Collaborator

Update RRFS control files:

  • Change the generating process ID to rrfs.
  • Only keep visibility calculated from GSL visibility algorithms.

@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 7, 2021 that may be closed by this pull request
Update RRFS products #359
Closed
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP regression tests were completed on WCOSS-Dell, WCOSS-Cray and Hera. The baseline for fv3lam will be recreated with this PR merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 11b75ff into NOAA-EMC:develop Aug 9, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 9, 2021
Closed
@WenMeng-NOAA WenMeng-NOAA deleted the post_rrfs_prd branch March 2, 2022 14:52
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@gsketefian
Maximize RRFS_CONUS_[25,13,3]km grids so they span as much of HRRR CO…
10be2e2 
…NUS domain as possible (NOAA-EMC#360)

## DESCRIPTION OF CHANGES:
### Main changes:
* Change grid parameters for the RRFS_COUNS_25km, RRFS_CONUS_13km, and RRFS_CONUS_3km grids so that they span as much of the HRRR CONUS domain as possible.  Note that this is done without regard to whether NX and NY are evenly divisible by LAYOUT_X and LAYOUT_Y because these restrictions were recently removed from the forecast model.
* Remove several checks on the grid parameters.  These are:
  (1) The check on whether NX and NY are evenly divisible by LAYOUT_X and LAYOUT_Y, respectively.  This restriction has been removed from the forecast model.
  (2) The check on BLOCKSIZE, i.e. whether the quantity (NX/LAYOUT_X)*(NY/LAYOUT_Y) is evenly divisible by BLOCKSIZE.  This already depends on restriction (1) being satisfied, so it cannot be satisfied if (1) is not satisfied.
  (3) The check on whether NY is evenly divisible by the number of write-component tasks per write-component group.  Tests were run with parameters that violated this test, and the model did not crash, so we assume this is no longer a restriction.
* Modify NCL plotting scripts to make them work with the latest version of the workflow.

### Bug fixes:
* Fix bug in set_predef_grid_params.sh involving an extra space after the equal sign in the lines that set GRID_GEN_METHOD.
* Remove the FV3_RRFS_v1alpha suite from the list of WE2E tests because that suite is not (yet?) supported by the version of ufs-weather-model this PR is using.
* Fix bug in run_experiment.sh where the variable FV3GFS_FILE_FMT_ICS should be replaced with FV3GFS_FILE_FMT_LBCS.

### Improvements:
* Forecast model executable:
  (1) Remove section of code that copies the FV3 executable from its location in the ufs-weather-model directory to the bin directory for all other executables.  This is no longer necessary since the new build system already places this executable in the bin directory.
  (2) Change the name of the forecast model executable to the latest one that is being used in ufs-weather-model.
* Remove commented-out code that was previously used to create module files for the various workflow tasks.
* Change the default physics suite to GFS_v15p2 to be consistent with the release/public-v1 branch.
* Alphabetize namelist variable entries in FV3.input.yml and input.nml.FV3.
* Edit comments.

## TESTS CONDUCTED:
Ran all 49 WE2E tests on Hera.  All except 5 tests succeeded.  The results are as follows:
```
  (1) DOT_OR_USCORE                                                    SUCCESS
  (2) GST_release_public_v1                                            SUCCESS
  (3) community_ensemble_008mems                                       SUCCESS
  (4) community_ensemble_2mems                                         SUCCESS
  (5) get_extrn_files_from_hpss_FV3GFS_FV3GFS                          SUCCESS
  (6) get_extrn_files_from_hpss_GSMGFS_GSMGFS                          SUCCESS
  (7) get_extrn_files_from_hpss_HRRR_RAP                               SUCCESS
  (8) get_extrn_files_from_hpss_RAP_RAP                                SUCCESS
  (9) grid_CONUS_25km_GFDLgrid_FV3GFS_FV3GFS                           SUCCESS
 (10) grid_CONUS_3km_GFDLgrid_FV3GFS_FV3GFS                            SUCCESS
 (11) grid_GSD_HRRR_AK_50km                                            SUCCESS
 (12) grid_GSD_RAP13km                                                 FAILURE
 (13) grid_RRFS_AK_13km_FV3GFS_FV3GFS                                  SUCCESS
 (14) grid_RRFS_AK_13km_RAP_RAP                                        FAILURE
 (15) grid_RRFS_AK_3km_FV3GFS_FV3GFS                                   SUCCESS
 (16) grid_RRFS_AK_3km_RAP_RAP                                         FAILURE
 (17) grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2      SUCCESS
 (18) grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta    SUCCESS
 (19) grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_GSD_SAR             SUCCESS
 (20) grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta         SUCCESS
 (21) grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2      SUCCESS
 (22) grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta    SUCCESS
 (23) grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR             SUCCESS
 (24) grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta         SUCCESS
 (25) grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2       SUCCESS
 (26) grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta     SUCCESS
 (27) grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_GSD_SAR              SUCCESS
 (28) grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta          SUCCESS
 (29) grid_RRFS_SUBCONUS_3km_FV3GFS_FV3GFS                             SUCCESS
 (30) grid_RRFS_SUBCONUS_3km_HRRR_RAP                                  FAILURE
 (31) nco_CONUS_25km_GFDLgrid                                          SUCCESS
 (32) nco_RRFS_CONUS_25km_HRRR_RAP                                     SUCCESS
 (33) nco_RRFS_CONUS_3km_FV3GFS_FV3GFS                                 SUCCESS
 (34) nco_RRFS_CONUS_3km_HRRR_RAP                                      SUCCESS
 (35) nco_RRFS_SUBCONUS_3km_HRRR_RAP                                   SUCCESS
 (36) nco_ensemble                                                     SUCCESS
 (37) new_ESGgrid                                                      SUCCESS
 (38) new_GFDLgrid                                                     SUCCESS
 (39) new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE    SUCCESS
 (40) new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE     SUCCESS
 (41) pregen_grid_orog_sfc_climo                                       SUCCESS
 (42) regional_001                                                     SUCCESS
 (43) regional_002                                                     SUCCESS
 (44) suite_FV3_CPT_v0                                                 FAILURE
 (45) suite_FV3_GFS_v15p2                                              SUCCESS
 (46) suite_FV3_GFS_v16beta                                            SUCCESS
 (47) suite_FV3_GSD_SAR                                                SUCCESS
 (48) suite_FV3_GSD_v0                                                 SUCCESS
 (49) suite_FV3_RRFS_v1beta                                            SUCCESS
```
The 5 failed tests (with information on the failures) are as follows:
```
 (12) grid_GSD_RAP13km
      Failed in most of the run_post tasks.
 (14) grid_RRFS_AK_13km_RAP_RAP
      Failed in the run_fcst task with "AVOST IN VILKA" messages.
 (16) grid_RRFS_AK_3km_RAP_RAP
      Failed in the run_fcst task with "AVOST IN VILKA" messages.
 (30) grid_RRFS_SUBCONUS_3km_HRRR_RAP
      Failed in the run_fcst task without a clear failure message.
 (44) suite_FV3_CPT_v0
      Failed in the run_fcst task with the following namelist read error:
      forrtl: severe (19): invalid reference to variable in NAMELIST input, unit -5, file Internal Formatted NML Read, line -1, position 13
```
Except for FV3_CPT_v0, the failed tests do not use the new RRFS_CONUS grids.  Thus, these failures are not related to the CONUS grid modifications.  The failure of FV3_CPT_v0 is likely due to a bad namelist variable specification and thus also unrelated to the CONUS grid modifications.

Note that all tests using grids for which NX and NY are not evenly divisible by LAYOUT_X and LAYOUT_Y, respectively (which include all 3 new versions of the RRFS_CONUS grids), and thus the quantity (NX/LAYOUT_X)*(NY/LAYOUT_Y) is not evenly divisible by BLOCKSIZE gave warnings of this kind in the log file for the run_fcst task:
`WARNING from PE   478: atmos_modeldefine_blocks_packed: domain (  59  65) is not an even divisor with definition (  32) - blocks will not be uniform with a remainder of   27
`
This warning should either be removed (since this restriction on BLOCKSIZE has been removed from the code) or, if having this remainder makes the model run less efficiently, be replaced by a different caution message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRogers-NOAA EricRogers-NOAA EricRogers-NOAA approved these changes

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA

@HuiyaChuang-NOAA HuiyaChuang-NOAA Awaiting requested review from HuiyaChuang-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RRFS products
2 participants
@WenMeng-NOAA @EricRogers-NOAA