Restrict UPP computation from undefined points #306

JesseMeng-NOAA · 2021-04-23T01:13:33Z

Commit for issue #240 restrict post computation from undefined points
Results from regression test, due to modification in MDLFLD.f blocks of IGET(389) and IGET(390)
Differences are shown only in the lateral boundaries of fv3r domain
fv3r_2019062000/PRSLEV06.tm00.diff
49:78715958:UGRD:planetary boundary layer:rpn_corr=0.99802:rpn_rms=0.328868
50:80993255:VGRD:planetary boundary layer:rpn_corr=0.999444:rpn_rms=0.209165

…utation from undefined points

…actor_2021q2

…om undefined points #240"

…n from undefined points

…nto HEAD

sorc/ncep_post.fd/FIXED.f

sorc/ncep_post.fd/MDL2P.f

sorc/ncep_post.fd/MDLFLD.f

sorc/ncep_post.fd/AVIATION.f

sorc/ncep_post.fd/BNDLYR.f

sorc/ncep_post.fd/CALHEL.f

sorc/ncep_post.fd/AVIATION.f

sorc/ncep_post.fd/BNDLYR.f

sorc/ncep_post.fd/CALHEL2.f

WenMeng-NOAA · 2021-04-26T13:50:05Z

This particular change looks good. We can further consider the other items mentioned in the related Issue thread.

Thanks for confirming. We will work on further changes based on your suggestions in another PR later.

sorc/ncep_post.fd/CALHEL3.f

sorc/ncep_post.fd/MISCLN.f

…ion from undefined points

sorc/ncep_post.fd/MISCLN.f

sorc/ncep_post.fd/SURFCE.f

sorc/ncep_post.fd/CLDRAD.f

WenMeng-NOAA · 2021-04-29T15:01:13Z

@JesseMeng-NOAA From my tests, the following applications have changed results, please double checking to ensure all changes are expected:
gfs--
[Wen.Meng@v71a1 ptmp]$ cat gfs.20200204/gfs.t00z.sfluxgrbf006.grib2.diff
95:257436356:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
97:261945855:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined

fv3lam--
[Wen.Meng@v71a1 ptmp]$ cat fv3r_2019062000_pe_test/PRSLEV06.tm00.diff
49:78715958:UGRD:planetary boundary layer:rpn_corr=0.99802:rpn_rms=0.328868
50:80993255:VGRD:planetary boundary layer:rpn_corr=0.999444:rpn_rms=0.209165
53:87161607:PBLREG:surface:rpn_corr=-nan:rpn_rms=undefined
830:1168346154:TSOIL:3 m underground:rpn_corr=-nan:rpn_rms=undefined
851:1205236172:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
852:1205705614:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
860:1210632406:LSPA:surface:rpn_corr=-nan:rpn_rms=undefined
861:1211101872:SNOM:surface:rpn_corr=-nan:rpn_rms=undefined
863:1212474374:BGRUN:surface:rpn_corr=-nan:rpn_rms=undefined
874:1229947882:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
879:1239245969:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
880:1239715411:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
910:1277941815:SWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
911:1278411257:LWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
912:1278880699:LRGHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
921:1290157173:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
937:1321875281:ULWRF:top of atmosphere:rpn_corr=-nan:rpn_rms=undefined
938:1322344723:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
940:1326220046:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined
942:1329476827:CSDSF:surface:rpn_corr=-nan:rpn_rms=undefined
1077:1645449046:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined
1078:1645918488:SNFALB:surface:rpn_corr=-nan:rpn_rms=undefined

[Wen.Meng@v71a1 ptmp]$ cat fv3r_2019062000_pe_test/NATLEV06.tm00.diff
21:31366773:LRGHR:1 hybrid level:rpn_corr=-nan:rpn_rms=undefined
41:59049609:LRGHR:2 hybrid level:rpn_corr=-nan:rpn_rms=undefined
61:86775605:LRGHR:3 hybrid level:rpn_corr=-nan:rpn_rms=undefined
81:114750316:LRGHR:4 hybrid level:rpn_corr=-nan:rpn_rms=undefined
101:142808322:LRGHR:5 hybrid level:rpn_corr=-nan:rpn_rms=undefined
121:171140983:LRGHR:6 hybrid level:rpn_corr=-nan:rpn_rms=undefined
141:199083649:LRGHR:7 hybrid level:rpn_corr=-nan:rpn_rms=undefined
161:227353152:LRGHR:8 hybrid level:rpn_corr=-nan:rpn_rms=undefined
181:254189277:LRGHR:9 hybrid level:rpn_corr=-nan:rpn_rms=undefined
201:280727893:LRGHR:10 hybrid level:rpn_corr=-nan:rpn_rms=undefined
221:307023845:LRGHR:11 hybrid level:rpn_corr=-nan:rpn_rms=undefined
241:333134304:LRGHR:12 hybrid level:rpn_corr=-nan:rpn_rms=undefined
261:359109272:LRGHR:13 hybrid level:rpn_corr=-nan:rpn_rms=undefined
281:384941420:LRGHR:14 hybrid level:rpn_corr=-nan:rpn_rms=undefined
301:410826036:LRGHR:15 hybrid level:rpn_corr=-nan:rpn_rms=undefined
321:436709599:LRGHR:16 hybrid level:rpn_corr=-nan:rpn_rms=undefined
341:462562308:LRGHR:17 hybrid level:rpn_corr=-nan:rpn_rms=undefined
361:488345862:LRGHR:18 hybrid level:rpn_corr=-nan:rpn_rms=undefined
381:514354671:LRGHR:19 hybrid level:rpn_corr=-nan:rpn_rms=undefined
401:540116088:LRGHR:20 hybrid level:rpn_corr=-nan:rpn_rms=undefined
421:565594149:LRGHR:21 hybrid level:rpn_corr=-nan:rpn_rms=undefined
441:590786339:LRGHR:22 hybrid level:rpn_corr=-nan:rpn_rms=undefined
461:615719786:LRGHR:23 hybrid level:rpn_corr=-nan:rpn_rms=undefined
481:640754263:LRGHR:24 hybrid level:rpn_corr=-nan:rpn_rms=undefined
501:665280114:LRGHR:25 hybrid level:rpn_corr=-nan:rpn_rms=undefined
521:689432579:LRGHR:26 hybrid level:rpn_corr=-nan:rpn_rms=undefined
541:713688388:LRGHR:27 hybrid level:rpn_corr=-nan:rpn_rms=undefined
561:737632166:LRGHR:28 hybrid level:rpn_corr=-nan:rpn_rms=undefined
581:761872099:LRGHR:29 hybrid level:rpn_corr=-nan:rpn_rms=undefined
601:784897581:LRGHR:30 hybrid level:rpn_corr=-nan:rpn_rms=undefined
621:808048090:LRGHR:31 hybrid level:rpn_corr=-nan:rpn_rms=undefined
641:832039254:LRGHR:32 hybrid level:rpn_corr=-nan:rpn_rms=undefined
661:855255251:LRGHR:33 hybrid level:rpn_corr=-nan:rpn_rms=undefined
681:877988297:LRGHR:34 hybrid level:rpn_corr=-nan:rpn_rms=undefined
701:900562819:LRGHR:35 hybrid level:rpn_corr=-nan:rpn_rms=undefined
721:922224677:LRGHR:36 hybrid level:rpn_corr=-nan:rpn_rms=undefined
741:944591270:LRGHR:37 hybrid level:rpn_corr=-nan:rpn_rms=undefined
761:967543211:LRGHR:38 hybrid level:rpn_corr=-nan:rpn_rms=undefined
781:989535203:LRGHR:39 hybrid level:rpn_corr=-nan:rpn_rms=undefined
801:1009963231:LRGHR:40 hybrid level:rpn_corr=-nan:rpn_rms=undefined
821:1026342121:LRGHR:41 hybrid level:rpn_corr=-nan:rpn_rms=undefined
841:1042079059:LRGHR:42 hybrid level:rpn_corr=-nan:rpn_rms=undefined
861:1057406970:LRGHR:43 hybrid level:rpn_corr=-nan:rpn_rms=undefined
881:1072404805:LRGHR:44 hybrid level:rpn_corr=-nan:rpn_rms=undefined
901:1086882405:LRGHR:45 hybrid level:rpn_corr=-nan:rpn_rms=undefined
921:1100908721:LRGHR:46 hybrid level:rpn_corr=-nan:rpn_rms=undefined
941:1115756458:LRGHR:47 hybrid level:rpn_corr=-nan:rpn_rms=undefined
961:1130676987:LRGHR:48 hybrid level:rpn_corr=-nan:rpn_rms=undefined
981:1145615858:LRGHR:49 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1001:1161335668:LRGHR:50 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1021:1177243943:LRGHR:51 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1041:1193381424:LRGHR:52 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1061:1209617474:LRGHR:53 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1081:1226120096:LRGHR:54 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1101:1242713200:LRGHR:55 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1121:1259267537:LRGHR:56 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1141:1276038160:LRGHR:57 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1161:1292908837:LRGHR:58 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1181:1310011063:LRGHR:59 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1201:1325581247:LRGHR:60 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1265:1467459238:TSOIL:3 m underground:rpn_corr=-nan:rpn_rms=undefined
1288:1508263555:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
1289:1508732997:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
1297:1513659789:LSPA:surface:rpn_corr=-nan:rpn_rms=undefined
1298:1514129255:SNOM:surface:rpn_corr=-nan:rpn_rms=undefined
1300:1515250398:BGRUN:surface:rpn_corr=-nan:rpn_rms=undefined
1310:1530597387:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
1315:1539895474:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
1316:1540364916:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
1336:1566079867:PRES:1-61 hybrid layer:rpn_corr=-nan:rpn_rms=undefined
1352:1583398845:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
1366:1610773339:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
1368:1614648662:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined
1370:1617905443:CSDSF:surface:rpn_corr=-nan:rpn_rms=undefined
1473:1851112071:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined

hafs--
[Wen.Meng@v71a1 ptmp]$ cat fv3hafs_2020082512/HURPRS09.tm00.diff
737:2611849226:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
743:2629397490:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
747:2644808743:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
748:2645684610:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
762:2694410543:LWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
763:2695286410:LRGHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
766:2702371087:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
775:2750305158:ULWRF:top of atmosphere:rpn_corr=-nan:rpn_rms=undefined
776:2751181025:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
778:2757650870:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined

hrrr--
[Wen.Meng@v71a1 ptmp]$ cat hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
8:3699655:REFD:263 K level:rpn_corr=-nan:rpn_rms=undefined
41:28777551:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
42:29015882:HGT:1000 mb:rpn_corr=-nan:rpn_rms=undefined
121:84914790:HGT:cloud base:rpn_corr=0.99507:rpn_rms=766.713
122:87453891:PRES:cloud base:rpn_corr=0.9952:rpn_rms=3228.28
171:157442339:SBT124:top of atmosphere:rpn_corr=0.999999:rpn_rms=0.0353183

rap--
[Wen.Meng@v71a1 ptmp]$ cat rap_2020072316_pe_test/WRFPRS.GrbF16.diff
622:165907322:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
623:166006860:HGT:1000 mb:rpn_corr=-nan:rpn_rms=undefined
697:190249885:HGT:cloud base:rpn_corr=0.988498:rpn_rms=1040.17
698:191422310:PRES:cloud base:rpn_corr=0.990164:rpn_rms=4848.41
708:195039649:CDCON:convective cloud layer:rpn_corr=-nan:rpn_rms=undefined

[Wen.Meng@v71a1 ptmp]$ cat rap_2020072316_pe_test/WRFNAT.GrbF16.diff
1004:258330139:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
1070:281976820:HGT:cloud base:rpn_corr=0.988498:rpn_rms=1040.17
1071:283149245:PRES:cloud base:rpn_corr=0.990164:rpn_rms=4848.41

JesseMeng-NOAA

Wen and Hui-Ya, looks like at this point neither CZEN and CZMEAN were ever calculated so both remain spval.
then calculation below
FACTRS = CZEN(I,J)/CZMEAN(I,J), so FACTRS=1.0, and
GRID1(I,J)=RSWIN(I,J)*FACTRS, which makes no adjustment
but if we validate CZEN and CZMEAN, GRID1 will be spval.

sorc/ncep_post.fd/CLDRAD.f

WenMeng-NOAA · 2021-04-29T16:17:23Z

The FV3 based model don't output czen and czmean. These two variables are assigned spval in read interface. I would think checking czen and czmean's spval values can be skipped. @HuiyaChuang-NOAA may chime in.

JesseMeng-NOAA · 2021-04-29T16:43:24Z

The FV3 based model don't output czen and czmean. These two variables are assigned spval in read interface. I would think checking czen and czmean's spval values can be skipped. @HuiyaChuang-NOAA may chime in.

Agree. I will check RSWIN instead.

JesseMeng-NOAA · 2021-04-29T16:44:15Z

@JesseMeng-NOAA From my tests, the following applications have changed results, please double checking to ensure all changes are expected:
gfs--
[Wen.Meng@v71a1 ptmp]$ cat gfs.20200204/gfs.t00z.sfluxgrbf006.grib2.diff
95:257436356:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
97:261945855:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined

fv3lam--
[Wen.Meng@v71a1 ptmp]$ cat fv3r_2019062000_pe_test/PRSLEV06.tm00.diff
49:78715958:UGRD:planetary boundary layer:rpn_corr=0.99802:rpn_rms=0.328868
50:80993255:VGRD:planetary boundary layer:rpn_corr=0.999444:rpn_rms=0.209165
53:87161607:PBLREG:surface:rpn_corr=-nan:rpn_rms=undefined
830:1168346154:TSOIL:3 m underground:rpn_corr=-nan:rpn_rms=undefined
851:1205236172:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
852:1205705614:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
860:1210632406:LSPA:surface:rpn_corr=-nan:rpn_rms=undefined
861:1211101872:SNOM:surface:rpn_corr=-nan:rpn_rms=undefined
863:1212474374:BGRUN:surface:rpn_corr=-nan:rpn_rms=undefined
874:1229947882:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
879:1239245969:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
880:1239715411:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
910:1277941815:SWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
911:1278411257:LWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
912:1278880699:LRGHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
921:1290157173:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
937:1321875281:ULWRF:top of atmosphere:rpn_corr=-nan:rpn_rms=undefined
938:1322344723:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
940:1326220046:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined
942:1329476827:CSDSF:surface:rpn_corr=-nan:rpn_rms=undefined
1077:1645449046:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined
1078:1645918488:SNFALB:surface:rpn_corr=-nan:rpn_rms=undefined

[Wen.Meng@v71a1 ptmp]$ cat fv3r_2019062000_pe_test/NATLEV06.tm00.diff
21:31366773:LRGHR:1 hybrid level:rpn_corr=-nan:rpn_rms=undefined
41:59049609:LRGHR:2 hybrid level:rpn_corr=-nan:rpn_rms=undefined
61:86775605:LRGHR:3 hybrid level:rpn_corr=-nan:rpn_rms=undefined
81:114750316:LRGHR:4 hybrid level:rpn_corr=-nan:rpn_rms=undefined
101:142808322:LRGHR:5 hybrid level:rpn_corr=-nan:rpn_rms=undefined
121:171140983:LRGHR:6 hybrid level:rpn_corr=-nan:rpn_rms=undefined
141:199083649:LRGHR:7 hybrid level:rpn_corr=-nan:rpn_rms=undefined
161:227353152:LRGHR:8 hybrid level:rpn_corr=-nan:rpn_rms=undefined
181:254189277:LRGHR:9 hybrid level:rpn_corr=-nan:rpn_rms=undefined
201:280727893:LRGHR:10 hybrid level:rpn_corr=-nan:rpn_rms=undefined
221:307023845:LRGHR:11 hybrid level:rpn_corr=-nan:rpn_rms=undefined
241:333134304:LRGHR:12 hybrid level:rpn_corr=-nan:rpn_rms=undefined
261:359109272:LRGHR:13 hybrid level:rpn_corr=-nan:rpn_rms=undefined
281:384941420:LRGHR:14 hybrid level:rpn_corr=-nan:rpn_rms=undefined
301:410826036:LRGHR:15 hybrid level:rpn_corr=-nan:rpn_rms=undefined
321:436709599:LRGHR:16 hybrid level:rpn_corr=-nan:rpn_rms=undefined
341:462562308:LRGHR:17 hybrid level:rpn_corr=-nan:rpn_rms=undefined
361:488345862:LRGHR:18 hybrid level:rpn_corr=-nan:rpn_rms=undefined
381:514354671:LRGHR:19 hybrid level:rpn_corr=-nan:rpn_rms=undefined
401:540116088:LRGHR:20 hybrid level:rpn_corr=-nan:rpn_rms=undefined
421:565594149:LRGHR:21 hybrid level:rpn_corr=-nan:rpn_rms=undefined
441:590786339:LRGHR:22 hybrid level:rpn_corr=-nan:rpn_rms=undefined
461:615719786:LRGHR:23 hybrid level:rpn_corr=-nan:rpn_rms=undefined
481:640754263:LRGHR:24 hybrid level:rpn_corr=-nan:rpn_rms=undefined
501:665280114:LRGHR:25 hybrid level:rpn_corr=-nan:rpn_rms=undefined
521:689432579:LRGHR:26 hybrid level:rpn_corr=-nan:rpn_rms=undefined
541:713688388:LRGHR:27 hybrid level:rpn_corr=-nan:rpn_rms=undefined
561:737632166:LRGHR:28 hybrid level:rpn_corr=-nan:rpn_rms=undefined
581:761872099:LRGHR:29 hybrid level:rpn_corr=-nan:rpn_rms=undefined
601:784897581:LRGHR:30 hybrid level:rpn_corr=-nan:rpn_rms=undefined
621:808048090:LRGHR:31 hybrid level:rpn_corr=-nan:rpn_rms=undefined
641:832039254:LRGHR:32 hybrid level:rpn_corr=-nan:rpn_rms=undefined
661:855255251:LRGHR:33 hybrid level:rpn_corr=-nan:rpn_rms=undefined
681:877988297:LRGHR:34 hybrid level:rpn_corr=-nan:rpn_rms=undefined
701:900562819:LRGHR:35 hybrid level:rpn_corr=-nan:rpn_rms=undefined
721:922224677:LRGHR:36 hybrid level:rpn_corr=-nan:rpn_rms=undefined
741:944591270:LRGHR:37 hybrid level:rpn_corr=-nan:rpn_rms=undefined
761:967543211:LRGHR:38 hybrid level:rpn_corr=-nan:rpn_rms=undefined
781:989535203:LRGHR:39 hybrid level:rpn_corr=-nan:rpn_rms=undefined
801:1009963231:LRGHR:40 hybrid level:rpn_corr=-nan:rpn_rms=undefined
821:1026342121:LRGHR:41 hybrid level:rpn_corr=-nan:rpn_rms=undefined
841:1042079059:LRGHR:42 hybrid level:rpn_corr=-nan:rpn_rms=undefined
861:1057406970:LRGHR:43 hybrid level:rpn_corr=-nan:rpn_rms=undefined
881:1072404805:LRGHR:44 hybrid level:rpn_corr=-nan:rpn_rms=undefined
901:1086882405:LRGHR:45 hybrid level:rpn_corr=-nan:rpn_rms=undefined
921:1100908721:LRGHR:46 hybrid level:rpn_corr=-nan:rpn_rms=undefined
941:1115756458:LRGHR:47 hybrid level:rpn_corr=-nan:rpn_rms=undefined
961:1130676987:LRGHR:48 hybrid level:rpn_corr=-nan:rpn_rms=undefined
981:1145615858:LRGHR:49 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1001:1161335668:LRGHR:50 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1021:1177243943:LRGHR:51 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1041:1193381424:LRGHR:52 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1061:1209617474:LRGHR:53 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1081:1226120096:LRGHR:54 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1101:1242713200:LRGHR:55 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1121:1259267537:LRGHR:56 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1141:1276038160:LRGHR:57 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1161:1292908837:LRGHR:58 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1181:1310011063:LRGHR:59 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1201:1325581247:LRGHR:60 hybrid level:rpn_corr=-nan:rpn_rms=undefined
1265:1467459238:TSOIL:3 m underground:rpn_corr=-nan:rpn_rms=undefined
1288:1508263555:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
1289:1508732997:SPFH:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
1297:1513659789:LSPA:surface:rpn_corr=-nan:rpn_rms=undefined
1298:1514129255:SNOM:surface:rpn_corr=-nan:rpn_rms=undefined
1300:1515250398:BGRUN:surface:rpn_corr=-nan:rpn_rms=undefined
1310:1530597387:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
1315:1539895474:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
1316:1540364916:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
1336:1566079867:PRES:1-61 hybrid layer:rpn_corr=-nan:rpn_rms=undefined
1352:1583398845:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
1366:1610773339:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
1368:1614648662:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined
1370:1617905443:CSDSF:surface:rpn_corr=-nan:rpn_rms=undefined
1473:1851112071:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined

hafs--
[Wen.Meng@v71a1 ptmp]$ cat fv3hafs_2020082512/HURPRS09.tm00.diff
737:2611849226:POT:10 m above ground:rpn_corr=-nan:rpn_rms=undefined
743:2629397490:EVP:surface:rpn_corr=-nan:rpn_rms=undefined
747:2644808743:UFLX:surface:rpn_corr=-nan:rpn_rms=undefined
748:2645684610:VFLX:surface:rpn_corr=-nan:rpn_rms=undefined
762:2694410543:LWHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
763:2695286410:LRGHR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
766:2702371087:CDLYR:entire atmosphere (considered as a single layer):rpn_corr=-nan:rpn_rms=undefined
775:2750305158:ULWRF:top of atmosphere:rpn_corr=-nan:rpn_rms=undefined
776:2751181025:DSWRF:surface:rpn_corr=-nan:rpn_rms=undefined
778:2757650870:USWRF:surface:rpn_corr=-nan:rpn_rms=undefined

hrrr--
[Wen.Meng@v71a1 ptmp]$ cat hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
8:3699655:REFD:263 K level:rpn_corr=-nan:rpn_rms=undefined
41:28777551:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
42:29015882:HGT:1000 mb:rpn_corr=-nan:rpn_rms=undefined
121:84914790:HGT:cloud base:rpn_corr=0.99507:rpn_rms=766.713
122:87453891:PRES:cloud base:rpn_corr=0.9952:rpn_rms=3228.28
171:157442339:SBT124:top of atmosphere:rpn_corr=0.999999:rpn_rms=0.0353183

rap--
[Wen.Meng@v71a1 ptmp]$ cat rap_2020072316_pe_test/WRFPRS.GrbF16.diff
622:165907322:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
623:166006860:HGT:1000 mb:rpn_corr=-nan:rpn_rms=undefined
697:190249885:HGT:cloud base:rpn_corr=0.988498:rpn_rms=1040.17
698:191422310:PRES:cloud base:rpn_corr=0.990164:rpn_rms=4848.41
708:195039649:CDCON:convective cloud layer:rpn_corr=-nan:rpn_rms=undefined

[Wen.Meng@v71a1 ptmp]$ cat rap_2020072316_pe_test/WRFNAT.GrbF16.diff
1004:258330139:MSLMA:mean sea level:rpn_corr=-nan:rpn_rms=undefined
1070:281976820:HGT:cloud base:rpn_corr=0.988498:rpn_rms=1040.17
1071:283149245:PRES:cloud base:rpn_corr=0.990164:rpn_rms=4848.41

Looking into it now.

WenMeng-NOAA · 2021-04-30T20:38:25Z

@JesseMeng-NOAA Could you sync your branch with upstream/dvelop?

…nto HEAD

JesseMeng-NOAA · 2021-04-30T21:03:19Z

@JesseMeng-NOAA Could you sync your branch with upstream/dvelop?

done

WenMeng-NOAA · 2021-05-03T13:11:59Z

@JesseMeng-NOAA Please do the final checking per @HuiyaChuang-NOAA and @BoCui-NOAA 's comments, take appropriate actions (keep or further mods) and mark comments as solved. Thanks!

JesseMeng-NOAA · 2021-05-03T13:43:30Z

Final check done. All output checked.
The fields show up in rt *.diff are due to one of the following reasons,

the entire field is undef in both rt base file AND the test file
boundaries of regional models
hrrr and rap pe test, Wen has mentioned it's associated with pending GSD unification
surface ALBEDO, fixed bug in current FIXED.f for uninitialized GRID1

Resolved.

WenMeng-NOAA · 2021-05-03T14:00:49Z

@JesseMeng-NOAA Please take actions in the comments MISCLN.F (either keep or further modifications) and mark as "conversation solved".

JesseMeng-NOAA · 2021-05-03T14:10:14Z

@JesseMeng-NOAA Please take actions in the comments MISCLN.F (either keep or further modifications) and mark as "conversation solved".

done

JesseMeng-NOAA and others added 6 commits April 14, 2021 17:39

20210414 Jesse Meng commit progress for Issue #240 restrict post comp…

6b6e297

…utation from undefined points

Merge remote-tracking branch 'upstream/develop' into feature/post_ref…

1915724

…actor_2021q2

20210416 Jesse Meng commit progress for "restrict post computation fr…

1e91749

…om undefined points #240"

Merge remote-tracking branch 'upstream/develop' into HEAD

e1038d8

20210422 Jesse Meng commit progress for #240 restrict post computatio…

2d7888e

…n from undefined points

20210422 Jesse Meng Merge remote-tracking branch 'upstream/develop' i…

54bf17b

…nto HEAD

JesseMeng-NOAA mentioned this pull request Apr 23, 2021

restrict post computation from undefined points #240

Closed

WenMeng-NOAA requested review from BoCui-NOAA and HuiyaChuang-NOAA April 23, 2021 13:12

WenMeng-NOAA mentioned this pull request Apr 23, 2021

Bug in GSD Visibility Computation #305

Closed

20210423 Jesse Meng fix bug in CALVIS_GSD PR#306

bdf6558

WenMeng-NOAA mentioned this pull request Apr 23, 2021

value of CONST1 used for visibility #302

Closed

WenMeng-NOAA linked an issue Apr 23, 2021 that may be closed by this pull request

Bug in GSD Visibility Computation #305

Closed

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/FIXED.f Outdated Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDL2P.f Outdated Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDL2P.f Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Outdated Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Outdated Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Outdated Show resolved Hide resolved

HuiyaChuang-NOAA reviewed Apr 23, 2021

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Show resolved Hide resolved

BoCui-NOAA reviewed Apr 25, 2021

View reviewed changes

sorc/ncep_post.fd/AVIATION.f Show resolved Hide resolved

BoCui-NOAA reviewed Apr 25, 2021

View reviewed changes

sorc/ncep_post.fd/BNDLYR.f Show resolved Hide resolved

BoCui-NOAA reviewed Apr 25, 2021

View reviewed changes

sorc/ncep_post.fd/CALHEL.f Outdated Show resolved Hide resolved