Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AQM to CMAQv5.4 #101

Draft
wants to merge 113 commits into
base: develop
Choose a base branch
from

Conversation

drnimbusrain
Copy link

@drnimbusrain drnimbusrain commented Jul 17, 2024

PR Checklist

Description

This PR provides all necessary updates to AQM develop branch for ARL's work to update CMAQv5.4 submodule (from current CMAQv5.2.1) and all necessary AQM infrastructure to accommodate the CMAQv5.4 changes compared. Since our CMAQv5.4 changes were built upon our fork of the EMC develop branch, then it also contains some initial developments of our in-canopy photolysis infrastructure and code developments. The canopy option is turned off by default, and at this time, we recommend that the canopy option remains turned OFF (in aqm.rc) until further refined developments of the canopy codes in AQM (and later in UFS-SRW-App, UWM, FV3/CCPP, etc. via separate corresponding PRs to their authoritative repos to enable full functionality).

Issue(s) addressed

#100

Dependencies

Updates to UFS-SRW-App at non-default branches (e.g., production/AQM.v7) are needed to accommodate the CMAQv5.4 updates in AQM (see new or updated data section above). The question remains as to where and how to make these PRs. Our changes for CMAQv5.4 were built upon the previous [aqm_dev] branch of UFS-SRW-App, and do not correspond to the production/AQM.v7 branch. Please advise and we can update and make the correct PR to the correct UFS-SRW-App branch to accommodate testing the CMAQv5.4 updates to AQM.

@lwcugb @bbakernoaa @ytangnoaa

Patrick.C.Campbell@noaa.gov and others added 30 commits February 10, 2022 21:27
Fixed Makefile.in typo.
ytangnoaa and others added 8 commits September 1, 2023 10:12
@JianpingHuang-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA Can you merge this PR?

@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA Can you merge this PR?

I think there is other work going on that will incorporate a bunch of things to get CMAQ 5.4 working. Let's get this figured out.

@ytangnoaa
Copy link

@BrianCurtis-NOAA Can you merge this PR?

Jianping. Please hold it. We may update it for some bugs.

lwcugb and others added 4 commits September 18, 2024 10:53
Better handle of the emission unit. This will not impact the simulation results.
Resolve a bug in point source emission. Only the first layer emission is included with his bug, which leads to much lower SO2 simulations.
Fix a bug in point source emission
@JianpingHuang-NOAA
Copy link
Collaborator

@ytangnoaa@lwcugb Do you have any preliminary results to share by using the latest code?

@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Sep 23, 2024

This supersedes #98
Could you change line 23 of CMakeLists.txt to: set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -g -check all -check noarg_temp_created -fpe0 -fno-alias -ftrapuv -traceback")

@ytangnoaa
Copy link

This supersedes #98 Could you change line 23 of CMakeLists.txt to: set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -g -check all -check noarg_temp_created -fpe0 -fno-alias -ftrapuv -traceback")

Updated the compiler flag.

@BrianCurtis-NOAA
Copy link
Collaborator

If you could test a build it would save me some time later today, but there might be some tweaks to some of the code to conform to those options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants