Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NIRALUser/ShapePopulationViewer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 762825c47a94bf316db7e1d6876d39c19c06640a
Choose a base ref
...
head repository: NIRALUser/ShapePopulationViewer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8112d7b1253a94426b510a53779c20118e483c1a
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Nov 28, 2018

  1. COMP: Fix Slicer extension windows build error removing setting of BU… 

    …ILD_SHARED_LIBS

Setting option BUILD_SHARED_LIBS is not required for the following reasons:
* the ShapePopulationViewWidget library is always built statically
* setting BUILD_SHARED_LIBS to OFF is causing the ShapePopulationViewer
  module to be statically build which is not supported.

Windows build error was the following:

qSlicerShapePopulationViewerModuleWidget::staticMetaObject': definition of dllimport static data member not allowed

Finally, explicitly include the ITKSetStandardCompilerFlags CMake module
to ensure the correct version is included.
    @jcfr
    jcfr committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    8112d7b View commit details
    Browse the repository at this point in the history
Loading