Fix nbextension installation and add E2E tests

Author: yacchin1205

.dockerignore

@@ -1,6 +1,14 @@
 lib/
 node_modules/
+components/lib/
+components/node_modules/
+nbextension/lib/
+nbextension/node_modules/
+nbextension/diff_match_patch.js
 lc_notebook_diff/labextension/
+lc_notebook_diff/nbextension/diff_match_patch.js
+lc_notebook_diff/nbextension/jupyter-notebook-diff.js
+lc_notebook_diff/nbextension/jupyter-notebook-diff.js.map
 *.tsbuildinfo
 ui-tests/test-results/
 ui-tests/playwright-report/

.github/workflows/e2e-tests.yml

@@ -72,6 +72,7 @@ jobs:
           E2E_DEFAULT_DELAY: '200'
           JUPYTERLAB_URL: 'http://localhost:8888/lab?token=test-token'
           NOTEBOOK7_URL: 'http://localhost:8888/tree?token=test-token'
+          NBCLASSIC_URL: 'http://localhost:8888/nbclassic/tree?token=test-token'
           JUPYTER_WORK_DIR: ${{ github.workspace }}/ui-tests/e2e-notebook/artifacts/jupyter-work
         run: |
           set -euxo pipefail

Dockerfile

@@ -15,7 +15,9 @@ ENV PATH=/.npm/bin/:${PATH}
 RUN pip install --no-cache  jupyter_nbextensions_configurator
 
 COPY . /tmp/notebook_diff
-RUN pip install --no-cache /tmp/notebook_diff
+RUN cd /tmp/notebook_diff/components && npm install && npm run build && \
+    cd /tmp/notebook_diff/nbextension && npm install && npm run build && \
+    pip install --no-cache /tmp/notebook_diff
 
 RUN jupyter labextension enable lc_notebook_diff
 

pyproject.toml

@@ -47,6 +47,7 @@ exclude = [".github", "binder"]
 [tool.hatch.build.targets.wheel.shared-data]
 "lc_notebook_diff/labextension" = "share/jupyter/labextensions/lc_notebook_diff"
 "install.json" = "share/jupyter/labextensions/lc_notebook_diff/install.json"
+"lc_notebook_diff/nbextension" = "share/jupyter/nbextensions/notebook_diff"
 
 [tool.hatch.build.hooks.version]
 path = "lc_notebook_diff/_version.py"

ui-tests/e2e-notebook/notebooks/03_Basic_Notebook_Diff_Test_NBClassic.ipynb

@@ -88,6 +88,10 @@ def main() -> int:
             if notebook7_url:
                 parameters["notebook7_url"] = notebook7_url
 
+            nbclassic_url = os.getenv("NBCLASSIC_URL")
+            if nbclassic_url:
+                parameters["nbclassic_url"] = nbclassic_url
+
             jupyter_work_dir = os.getenv("JUPYTER_WORK_DIR")
             if jupyter_work_dir:
                 parameters["jupyter_work_dir"] = jupyter_work_dir