Entity Remarks

[huwsteadCL]

Section 2.7.4.3 of the RDAP Response Profile states that a remarks element is required for the contact where information has been redacted.

While there is an entity_remarks table the application doesn't seem to pull from this table when building a response to a domain query and as such I can't see how to add remarks to a contact entity to be displayed in the response. Could you advise?

[dhfelix]

About section 2.7.4.3, the RDAP-server handle this by activating the privacy utility, the remark is added when the privacy settings hide some value of the object that process, this is our way of complying with the profile.

Although it is true, it is necessary to add a little more information to that remark, i.e. the title of the remark.
This will be resolved in the next version of rdap-server, soon to be released.

About your second point. When we did the reference implementation of the rdap-data-access-api (a.k.a. rdap-sql-provider), we decided to omit some fields in the second-level objects, e.g. Do not show all the information of an Entity when it comes nested within a Domain, a first level Entity shows all its information.

We have added information to the second level objects when this is dictated to us by an RFC or also by the ICANN profile.

As section 2.7.4.3 is covered by the rdap-server, we did not see the need to add that field in the rdap-sql-provider.

We will check if we have time to get a new version with the requirement for the rdap-sql-provider, meanwhile feel free to modify the rdap-sql-provider code.

Do not hesitate to write in this issue if you have more questions.

[dhfelix]

You can add the next two lines of code in EntityModel#setNestedSimpleObjects project rdap-sql-provider, in order to read remarks in nested entity objects.

			List<Remark> remarks = RemarkModel.getByEntityId(entityId, connection);
			entity.getRemarks().addAll(remarks);

[huwsteadCL]

Thanks for the code snippet.

I think on this one we are going to need to go down the code modification route as I can't see exactly how activating the privacy policy is going to meet our aims here

[huwsteadCL]

Hi - In regards to this issue which was closed based on an earlier commit. Does this mean that I should now see entity remarks for redacted contacts within a response (assuming the correct remark and entity_remarks configuration)?

[dhfelix]

Argh... This issue was not intended to be closed with the commit.

We did not modify the rdap-sql-provider, so the behavior is the same when this issue was open.

But the remark for the section 2.7.4.3 is added when privacy is handled by the rdap-server (https://www.reddog.mx/response-privacy.html).

[huwsteadCL]

So your comment above and the tweaks made for #98 satisfy my requirements for our implementation.

So.. No need to hold open on my behalf any longer

Thanks
Huw