FLAGSAPI-1091 Remove lxml dependency

Author: gps035

poetry.lock

@@ -4,15 +4,30 @@
 import uuid
 from time import time
 from urllib.parse import parse_qs, urlparse
+from html.parser import HTMLParser
 
 import jwt
 import requests
-from lxml import html
 
 from .credentials import get_credentials
 from .dot_proxygen import token_cache_file
 
 
+class KeycloakFormParser(HTMLParser):
+    action = None
+
+    def handle_starttag(self, tag, attrs):
+        if tag != 'form':
+            return
+
+        attributes = dict(attrs)
+
+        if attributes.get('id') != "kc-form-login":
+            return
+
+        self.action = attributes.get('action')
+
+
 def cache_key():
     s = get_credentials().json()
     return hashlib.md5(s.encode("utf-8")).hexdigest()
@@ -106,11 +121,10 @@ def _get_token_data_from_user_login():
             f"Login page get request status was {login_page_resp.status_code} expected to be 200"
         )
 
-    login_form = html.fromstring(login_page_resp.content.decode()).get_element_by_id(
-        "kc-form-login"
-    )
+    parser = KeycloakFormParser()
+    parser.feed(login_page_resp.content.decode())
+    url = parser.action
 
-    url = login_form.action
     user_login_resp = session.post(
         url,
         headers={
@@ -180,4 +194,4 @@ def _get_token_data_from_machine_user():
         raise RuntimeError(
             f"Token response was {token_response.status_code} expected 200"
         )
-    return token_response.json()
+    return token_response.json()

proxygen_cli/lib/auth.py

@@ -16,7 +16,6 @@ pydantic = "^1.9.1"
 click = "^8.1.3"
 pyjwt = "^2.3.0"
 requests = "^2.27.1"
-lxml = "^4.7.1"
 cryptography = ">=42,<44"
 pyyaml = "^6.0"
 yaspin = "^2.2.0"