Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NHSDigital/eps-assist-me
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: NHSDigital/eps-assist-me
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: AEA-6053-document-preprocessing
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 28 files changed
  • 2 contributors

Commits on Dec 10, 2025

  1. feat: preproccessing lambda

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    592b082 View commit details
    Browse the repository at this point in the history

  2. chore: adds skip quality check option in PR

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    2b181d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2025

  1. Merge branch 'main' into AEA-6053-document-preprocessing

    @Beenyaa
    Beenyaa committed Dec 30, 2025
    Configuration menu
    Copy the full SHA
    3ce4dad View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2026

  1. feat: infrastructure for document preproccessing

    @Beenyaa
    Beenyaa committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    2a03e44 View commit details
    Browse the repository at this point in the history

  2. feat: move cli usecase

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    e99217d View commit details
    Browse the repository at this point in the history

  3. feat: move cli usecase & comments

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    a73123d View commit details
    Browse the repository at this point in the history

  4. tests and poetry update

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    5fb91e2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into AEA-6053-document-preprocessing

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    5ea97f8 View commit details
    Browse the repository at this point in the history

  6. chore: merge conflict

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    0e253e5 View commit details
    Browse the repository at this point in the history

  7. chore: new lambda dependencies

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    11e2d03 View commit details
    Browse the repository at this point in the history

  8. chore: nag suppression

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    a05d9b5 View commit details
    Browse the repository at this point in the history

  9. trigger build #skip-qc

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    89fb9e4 View commit details
    Browse the repository at this point in the history

  10. chore: skip-qc stuff

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    6261d89 View commit details
    Browse the repository at this point in the history

  11. trigger build #skip-qc

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 5, 2026
    Configuration menu
    Copy the full SHA
    15dd8b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2026

  1. chore: stubs out magika package to reduce package size

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    a284233 View commit details
    Browse the repository at this point in the history

  2. chore: poetry

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    7d64811 View commit details
    Browse the repository at this point in the history

  3. chore: trying aggressive deps cleanup to reduce size

    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    22db2ad View commit details
    Browse the repository at this point in the history

  4. feat: auto-create S3 folders and grant KMS access to preprocessing la… 

    …mbda

Two fixes for preprocessing Lambda:

1. Grant KMS permissions: Added kmsKey.grantEncryptDecrypt() to allow
   Lambda to decrypt files from raw/ and encrypt files to processed/

2. Auto-create folders: Use BucketDeployment to create raw/ and
   processed/ folders on stack deployment. Much simpler than custom
   resource approach.

Files:
- packages/cdk/assets/s3-folders/raw/.gitkeep
- packages/cdk/assets/s3-folders/processed/.gitkeep
- packages/cdk/stacks/EpsAssistMeStack.ts
    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    7c597c3 View commit details
    Browse the repository at this point in the history

  5. fix: add cdk-nag suppressions for BucketDeployment and preprocessing KMS 

    Suppress cdk-nag warnings for:
- BucketDeployment IAM managed policy usage
- BucketDeployment wildcard S3/KMS permissions
- BucketDeployment Lambda runtime
- Preprocessing Lambda KMS wildcard permissions (GenerateDataKey*, ReEncrypt*)
    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    320c3fa View commit details
    Browse the repository at this point in the history

  6. fix: S3Bucket was using undefined KMS key 

    Critical bug: S3Bucket constructor was using this.kmsKey before it was assigned.
Changed line 34 from 'encryptionKey: this.kmsKey' to 'encryptionKey: kmsKey'
to use the local variable that was already created.

This prevented the bucket from being properly encrypted with our KMS key,
which is why the preprocessing Lambda couldn't decrypt objects.
    @bencegadanyi1-nhs
    bencegadanyi1-nhs committed Jan 6, 2026
    Configuration menu
    Copy the full SHA
    b8d771c View commit details
    Browse the repository at this point in the history
Loading