Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Citation Date showing not the right date #282

Open
nkurtys opened this issue Oct 8, 2024 · 3 comments · Fixed by #287
Open

Fix Citation Date showing not the right date #282

nkurtys opened this issue Oct 8, 2024 · 3 comments · Fixed by #287
Assignees

Comments

@nkurtys
Copy link
Collaborator

nkurtys commented Oct 8, 2024

While working on issue #93 I founds following issue:
The Date generated in the citation of the Knowledge Base page as well the "created at" part seem to not line up with the actual dates edited.

@nkurtys
Copy link
Collaborator Author

nkurtys commented Oct 10, 2024

  • the date seems to always be the current date
  • the date works as intended when used on a local machine

@nkurtys
Copy link
Collaborator Author

nkurtys commented Oct 10, 2024

There are two solutions:

  • add fetch-depth: 0 to fetch the entire history, but that can be slow depending on repo history.
  • concatenating git fetch --unshallow && onto the build command

Source: gjtorikian/jekyll-last-modified-at#69

@nkurtys nkurtys linked a pull request Oct 11, 2024 that will close this issue
@nkurtys
Copy link
Collaborator Author

nkurtys commented Oct 11, 2024

fetch-depth: 0 fixed it on github pages but not on the nfdi subdomain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants