Skip to content

Commit ceb7474

Browse files
committed
fix: remove duplicate e2e test run
1 parent 3edc1b1 commit ceb7474

File tree

3 files changed

+14
-40
lines changed

3 files changed

+14
-40
lines changed

.github/workflows/dev-build.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,22 @@ jobs:
3434
- uses: actions/checkout@v3
3535
- uses: actions/setup-node@v3
3636
with:
37-
node-version: 16.x
37+
node-version: 18.x
3838
- name: Install dependencies
3939
run: npm ci
4040
- name: Install Playwright
4141
run: npx playwright install --with-deps
4242
- name: Build test application
43-
env:
44-
NODE_OPTIONS: '--max_old_space_size=4096'
4543
run: npm run build-no-minify
4644
- name: Run E2E tests on ${{ matrix.project }}
4745
run: npx playwright test --project ${{ matrix.project }}
4846
continue-on-error: ${{ matrix.project == 'webkit' }}
47+
- name: Upload test results
48+
if: always()
49+
uses: actions/upload-artifact@v3
50+
with:
51+
name: test-results-${{ matrix.project }}
52+
path: test-results
4953

5054
lint:
5155
runs-on: ubuntu-latest

.github/workflows/e2e.yml

Lines changed: 0 additions & 34 deletions
This file was deleted.

.github/workflows/release-please.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,22 @@ jobs:
2626
- uses: actions/checkout@v3
2727
- uses: actions/setup-node@v3
2828
with:
29-
node-version: 16.x
29+
node-version: 18.x
3030
- name: Install dependencies
3131
run: npm ci
3232
- name: Install Playwright
3333
run: npx playwright install --with-deps
3434
- name: Build test application
35-
env:
36-
NODE_OPTIONS: '--max_old_space_size=4096'
3735
run: npm run build-no-minify
3836
- name: Run E2E tests on ${{ matrix.project }}
3937
run: npx playwright test --project ${{ matrix.project }}
4038
continue-on-error: ${{ matrix.project == 'webkit' }}
39+
- name: Upload test results
40+
if: always()
41+
uses: actions/upload-artifact@v3
42+
with:
43+
name: test-results-${{ matrix.project }}
44+
path: test-results
4145

4246
lint:
4347
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)