Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Public Docker Image #314

Closed
Outridair opened this issue Jan 25, 2023 · 2 comments · Fixed by #316
Closed

Create Public Docker Image #314

Outridair opened this issue Jan 25, 2023 · 2 comments · Fixed by #316
Assignees
@tariqksoliman

Comments

@Outridair
Copy link

As a user, I would like to be able to pull down the public docker image without having to build the project locally first.
@tariqksoliman tariqksoliman self-assigned this Jan 25, 2023
@tariqksoliman
Copy link
Member

Great idea!
DockerHub Personal accounts allow unlimited public repos for oss: https://www.docker.com/pricing/

One wrinkle is that, if used, the PUBLIC_URL needs to set before building. It might make sense to push two images:

  • One for MMGIS served at {domain}/
  • Another for MMGIS served at {domain}/mmgis

CI/CD would be nice too.

@jamesmontalvo3 jamesmontalvo3 mentioned this issue Jan 26, 2023
Merged
@jamesmontalvo3
Copy link
Contributor

Submitted #316 to build images in GitHub Actions and push to GitHub Container Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tariqksoliman tariqksoliman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: build docker image and push to GitHub Container Registry jamesmontalvo3/MMGIS
3 participants
@jamesmontalvo3 @Outridair @tariqksoliman