[jsonrpc] - Mark Transaction Builder RPC as unsafe #9226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
patrickkuo
force-pushed
the
pat/mark_transaction_builder_unsafe
branch
from
bd623bc to
3401bcd
Compare
patrickkuo
force-pushed
the
pat/mark_transaction_builder_unsafe
branch
from
3401bcd to
85a582e
Compare
gegaowp
approved these changes
Mar 14, 2023
because this is building the transaction remotely, if a app is connecting to a untrusted full node and use the transaction builder APIs, the malicious full node can potentially manipulate the transaction bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description