wallet-ext: copy to clipboard use toast for confirmation feedback #7583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchrysochoidis
requested review from
Jibz1,
mystie711,
Jordan-Mysten and
mamos-mysten
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
| }; | ||
|
|
||
| export function useCopyToClipboard( | ||
| txpToCopy: string, |
There was a problem hiding this comment.
Thanks renamed it
|
Is the toast height correct? |
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-295-ui-remove-keypair
branch
from
8910aaa to
3c29e5d
Compare
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-296-home-account-switch
branch
2 times, most recently
from
064ab94 to
e5c4199
Compare
Should be the same as it already is in main, I did't change it. |
Could you please double check if we are using the correct size in main? |
There was some extra margin from the lib, addressed here |
Jibz1
previously approved these changes
Jan 26, 2023
pchrysochoidis
added a commit
that referenced
this pull request
Jan 26, 2023
| before | after | | - | - | | <img width="417" alt="Screenshot 2023-01-26 at 18 13 51" src="https://user-images.githubusercontent.com/10210143/214917095-59a744a2-d728-48db-875f-a41f93a52f01.png"> | <img width="417" alt="Screenshot 2023-01-26 at 18 14 05" src="https://user-images.githubusercontent.com/10210143/214917146-6999f18b-95fc-48da-bf04-e5fc45ee1afa.png"> | addresses #7583 (comment)
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-296-home-account-switch
branch
from
e5c4199 to
f69dd7e
Compare
pchrysochoidis
requested review from
asonnino,
akichidis,
randall-Mysten,
ronny-mysten,
joyqvq,
kchalkias and
benr-ml
as code owners
pchrysochoidis
changed the base branch from
pc-wallet-ext-apps-295-ui-remove-keypair
to
main
Jibz1
reviewed
Jan 27, 2023
| return ( | ||
| <span | ||
| className={cl(st.container, className)} | ||
| onClick={!copyOnlyOnIconClick ? copyToClipboard : undefined} | ||
| > | ||
| {children} | ||
| <Icon | ||
| className={cl(st.copyIcon, st[mode], { [st.copied]: copied })} | ||
| className={cl(st.copyIcon, st[mode])} |
There was a problem hiding this comment.
We can but this component has other usages of css modules and classes and I think it's better to address them in an another PR that will do only that
Jibz1
approved these changes
Jan 27, 2023
* show a toast instead of scaling the copy icon * move copy to functionality to hooks to reuse it * also removes unused code for rendering sui objects
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-296-home-account-switch
branch
from
f69dd7e to
c84fb26
Compare
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
| before | after | | - | - | | <img width="417" alt="Screenshot 2023-01-26 at 18 13 51" src="https://user-images.githubusercontent.com/10210143/214917095-59a744a2-d728-48db-875f-a41f93a52f01.png"> | <img width="417" alt="Screenshot 2023-01-26 at 18 14 05" src="https://user-images.githubusercontent.com/10210143/214917146-6999f18b-95fc-48da-bf04-e5fc45ee1afa.png"> | addresses #7583 (comment)
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
) * show a toast instead of scaling the copy icon * move copy to functionality to hooks to reuse it * also removes unused code for rendering sui objects before https://user-images.githubusercontent.com/10210143/214037484-97443686-66eb-49bc-a550-fe39c7d6aa69.mov after https://user-images.githubusercontent.com/10210143/214036853-6cf71f8e-7b8e-4dda-acf5-c4c64d5fd3f9.mov https://user-images.githubusercontent.com/10210143/214036872-53ca8228-75bc-4135-aa1a-71e643e92252.mov part of APPS-296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
Screen.Recording.2023-01-23.at.12.14.26.mov
after
Screen.Recording.2023-01-23.at.12.11.12.mov
Screen.Recording.2023-01-23.at.12.11.34.mov
part of APPS-296