[explorer] Migrate end-to-end tests to Playwright #7116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Jordan-Mysten
changed the title
Jordan-Mysten
requested review from
randall-Mysten and
ronny-mysten
as code owners
666lcz
approved these changes
Jan 5, 2023
pchrysochoidis
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates our Explorer end-to-end tests from Cypress to Playwright. The test execution happens in Node.js which simplifies quite a bit of our setup because we can avoid the task indirection to drive the network. I was also able to to consolidate all of the tests using a multi-project setup, which makes the legacy tests a little easier to maintain / run (and will save us time in CI). Playwright is also able to start all of the relevant web servers for us (including localnet) which makes running tests super simple.
Playwright also has some utilities for testing Chrome Extensions, which should let us write extension tests for the wallet extension which would be very nice to have.