update activities to include events coinBalance #6953
Conversation
Jibz1
commented
Dec 20, 2022
Jibz1
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jibz1
force-pushed
the
wallet-update-txn-activities
branch
from
b99cbc8 to
e6d6132
Compare
apps/wallet/src/ui/app/pages/dapp-tx-approval/TransactionSummaryCard.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| /// Group coins by receiverAddress | ||
| // sum coins by coinType for each receiverAddress | ||
| const meta = coinsMeta.reduce((acc, value, _) => { |
There was a problem hiding this comment.
Why not just remove the _ argument?
| /// Group coins by receiverAddress | ||
| // sum coins by coinType for each receiverAddress | ||
| const meta = coinsMeta.reduce((acc, value, _) => { | ||
| return { |
There was a problem hiding this comment.
I wonder if this would be cleaner to just do this when you construct coinsMeta instead. Instead of a map just make it a forEach where you insert into an existing object. Seems like it'd simplify things.
Jibz1
force-pushed
the
wallet-update-txn-activities
branch
from
e6d6132 to
ceb6bf9
Compare
| return [ | ||
| { label: 'Transaction Type', content: 'MoveCall' }, |
There was a problem hiding this comment.
V2 transactions aren't just move calls. They can be any transaction type (Pay, TransferObject, MoveCall, etc). You should adjust this to account for that.
There was a problem hiding this comment.
reverted to tx.data.kind
| ) | ||
| )} | ||
| {valuesContent | ||
| .slice(1) |
There was a problem hiding this comment.
I'm curious why this slice is being done?
There was a problem hiding this comment.
just removes the 'Transaction Type: ... item since we display that as the title.
