[checkpoints] [small] Split CheckpointBuilder scope #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtian
approved these changes
Dec 6, 2022
crates/mysten-metrics/src/lib.rs
Outdated
| @@ -135,3 +138,29 @@ pub fn monitored_scope(name: &'static str) -> Option<MonitoredScopeGuard> { | |||
| None | |||
| } | |||
| } | |||
|
|
|||
| pub trait ScopeFutureExt: Future + Sized { | |||
| fn in_scope(self, name: &'static str) -> ScopeFuture<Self>; | |||
There was a problem hiding this comment.
Can we name this in_monitored_scope or something more appropriate, so readers can see its purpose easily?
Currently, CheckpointBuilder scope(fka `MakeCheckpoint`) shows nearly 100% utilization, most likely due to notify_read. This moves CheckpointBuilder (fka `MakeCheckpoint`) after notify_read and introduces separate scope for notify read only. This diff also introduces `in_scope` helper method for futures.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CheckpointBuilder scope(fka
MakeCheckpoint) shows nearly 100% utilization, most likely due to notify_read.This moves CheckpointBuilder after notify_read and introduces separate scope for notify read only.
This diff also introduces
in_scopehelper method for futures.