chore: Remove duplicate keytool sign in README #5530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Documentation
joyqvq
commented
Oct 25, 2022
| ] | ||
| }' | ||
| ``` | ||
|
|
There was a problem hiding this comment.
https://github.com/MystenLabs/sui/pull/5530/files#diff-60958f8d2cfb073726cf0ad61ec376d78202f84662b5496596cc76edf991bafcR77 IMO we just need to keep this one? the three copies seemed like a source of confusion
joyqvq
commented
Oct 25, 2022
doc/src/build/json-rpc.md
Outdated
| ] | ||
| }' | ||
| ``` | ||
|
|
||
| The command generates a package object that represents the published Move code. You can use the package ID as an argument for subsequent Move calls to functions defined in this package. |
There was a problem hiding this comment.
I don't know if this should be removed too, it does not make much sense here 🤔
joyqvq
commented
Oct 25, 2022
| ] | ||
| }' | ||
| ``` | ||
|
|
||
| Arguments are passed in, and type is inferred from the function |
There was a problem hiding this comment.
I don't know if 159-166 is needed too, it is not anywhere coherent with the context
joyqvq
changed the title
huitseeker
approved these changes
Nov 1, 2022
joyqvq
force-pushed
the
encrypt-keystore0
branch
from
2eabb56 to
8e284b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the same instruction (keytool sign and rpc execute) appeared three times in this doc, does it look redundant? I don't see any reason why, but want to double check