Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename order -> transaction #521

Merged
merged 1 commit into from
Feb 22, 2022
Merged

chore: rename order -> transaction #521

merged 1 commit into from
Feb 22, 2022

Conversation

huitseeker
Copy link
Contributor

Fixes #272

@huitseeker huitseeker merged commit d1b7d5b into MystenLabs:main Feb 22, 2022
@velvia
Copy link
Contributor

velvia commented Feb 23, 2022

Bummer just missed this. Would it have been clearer to have say TransactionRequest as opposed to just Transaction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfind lxfind lxfind approved these changes

@sblackshear sblackshear Awaiting requested review from sblackshear

@gdanezis gdanezis Awaiting requested review from gdanezis

@oxade oxade Awaiting requested review from oxade

@patrickkuo patrickkuo Awaiting requested review from patrickkuo

@velvia velvia Awaiting requested review from velvia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cleanup] Unify "order" and "transaction"
3 participants
@huitseeker @velvia @lxfind