Bump fastcrypto #5147
Merged
Bump fastcrypto #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-lj
requested review from
akichidis,
huitseeker,
asonnino and
kchalkias
as code owners
jonas-lj
commented
Oct 14, 2022
| "DeleteObject", | ||
| "NewObject", | ||
| "EpochChange", | ||
| "Checkpoint" |
There was a problem hiding this comment.
I don't know why it was necessary to update the schema here, but it could be because of some updated dependencies through fastcrypto.
kchalkias
approved these changes
Oct 15, 2022
Yea, Francois reminded me. I'll make sure to do that in the future. And thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the large PR, but there have been a few changes to the fastcrypto api, so in order to bump the version, we need to change a few things in sui. It's mostly just changes in paths and small changes to the api.
The fastcrypto version in mysten-util-mem (and afterwards, the mysten-util-mem depdency here) needs to be updated before this is merged.
Unintentionally, I've had to update the openrpc.json schema in order for the test_json_rpc_spec test to pass. I'm not sure why this is necessary, but it may be due to some updated dependencies pulled in from fastcrypto.