Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start json-rpc.md deduplication #3960

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Start json-rpc.md deduplication #3960

merged 1 commit into from
Aug 15, 2022

Conversation

Romainua
Copy link
Contributor

@Romainua Romainua commented Aug 13, 2022

Removed some contents that is in https://docs.sui.io/sui-jsonrpc. Some content requires comments for further updates.

sui_syncAccountState some of content does not use in https://docs.sui.io/sui-jsonrpc maybe need to update Sui JSON-RPC befor remove.

sui_transferObject it looks like example how to use sui_transferObject, include sui_transferObject and sui_executeTransaction methods.

sui_moveCall looks like sui_transferObject example, include sui_moveCall and refers to sui_executeTransaction in sui_transferObject

sui_publish also example how to use, include sui_publish method and refers to sui_executeTransaction in sui_transferObject

I have been remove what can be duplicate, it may seem that the other methods can also be duplicate, but those are more detailed example of how they can be used. We can remove these, but I think we can change and save it for the detail example in https://docs.sui.io/sui-jsonrpc

@Clay-Mysten I hope I did what you expected. Sorry for crated new pr, had to delete previous commits.

Removed what could happen again. Some content requires commands for further updates.
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Aug 13, 2022
@Clay-Mysten Clay-Mysten requested review from patrickkuo and removed request for randall-Mysten August 15, 2022 16:04
@Clay-Mysten Clay-Mysten self-assigned this Aug 15, 2022
@Clay-Mysten
Copy link
Contributor

Removed some contents that is in https://docs.sui.io/sui-jsonrpc. Some content requires comments for further updates.

sui_syncAccountState some of content does not use in https://docs.sui.io/sui-jsonrpc maybe need to update Sui JSON-RPC befor remove.

sui_transferObject it looks like example how to use sui_transferObject, include sui_transferObject and sui_executeTransaction methods.

sui_moveCall looks like sui_transferObject example, include sui_moveCall and refers to sui_executeTransaction in sui_transferObject

sui_publish also example how to use, include sui_publish method and refers to sui_executeTransaction in sui_transferObject

I have been remove what can be duplicate, it may seem that the other methods can also be duplicate, but those are more detailed example of how they can be used. We can remove these, but I think we can change and save it for the detail example in https://docs.sui.io/sui-jsonrpc

@Clay-Mysten I hope I did what you expected. Sorry for crated new pr, had to delete previous commits.

@Romainua you are my hero! Thanks for starting the deduplication and conducting the initial analysis. I have added @patrickkuo to take a look at the change and the comments regarding other methods above.

I will help finish this work up based upon our results here. Thank you both!

@Clay-Mysten Clay-Mysten changed the title Update json-rpc.md Start json-rpc.md deduplication Aug 15, 2022
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Romainua, really appreciate your contribution!!

@patrickkuo patrickkuo merged commit a62be30 into MystenLabs:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants