[bugfix] - Stack overflow when installing Sui binaries on windows #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
force-pushed
the
pat/stack_fix_for_windows
branch
from
8dacbe0 to
bf15d60
Compare
patrickkuo
changed the title
patrickkuo
force-pushed
the
pat/stack_fix_for_windows
branch
from
bf15d60 to
243596c
Compare
bmwill
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes stack overflow issue when installing Sui on windows.
Prior to this PR, we fixed the SO issue by adding
rustflags = [ "-C", "link-args=/STACK:64000000" ]to.cargo/configfile, this works if we are usingcargo buildwith local repo, however it won't work for installation from gitcargo install --git.