Minor cleanups in authority batch code #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
commented
Jun 6, 2022
crates/sui-core/src/safe_client.rs
Outdated
| @@ -395,7 +395,7 @@ where | |||
|
|
|||
| // We check if we have exceeded the batch boundary for this request. | |||
| // This is to protect against server DoS | |||
| if *count > 10 * request.length { | |||
| if *count > 10 + request.length { | |||
There was a problem hiding this comment.
This is the only functional change
lxfind
force-pushed
the
authority-random-cleanups
branch
from
80caa11 to
62b51d3
Compare
gdanezis
approved these changes
Jun 6, 2022
lxfind
force-pushed
the
authority-random-cleanups
branch
from
62b51d3 to
7fba095
Compare
stella3d
pushed a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes are minor cleanups, such as comments, style fixes, renaming and etc.
The only functional change is the DoS prevention, which I will highlight with a comment