Checkpoint integration test #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asonnino
requested review from
bmwill,
gdanezis,
huitseeker and
lxfind
and removed request for
huitseeker
asonnino
commented
May 31, 2022
gdanezis
approved these changes
Jun 3, 2022
| @@ -147,6 +154,7 @@ impl AuthorityServer { | |||
| pub struct ValidatorService { | |||
| state: Arc<AuthorityState>, | |||
| consensus_adapter: ConsensusAdapter, | |||
| _checkpoint_consensus_handle: Option<JoinHandle<()>>, | |||
There was a problem hiding this comment.
Hm, this is not going to be so simple, since we will need to restart it upon reconfiguration? We will work out the right structure down the line.
| @@ -295,7 +302,7 @@ pub struct CheckpointConsensusAdapter { | |||
| /// Receive new checkpoint fragments to sequence. | |||
| rx_checkpoint_consensus_adapter: Receiver<CheckpointFragment>, | |||
| /// A pointer to the checkpoints local store. | |||
| checkpoint_locals: ArcSwapOption<CheckpointLocals>, | |||
| checkpoint_locals: Arc<CheckpointLocals>, | |||
There was a problem hiding this comment.
Thank you for this! Indeed we do not need a swap here.
| pub fn spawn(mut instance: Self) -> JoinHandle<()> { | ||
| tokio::spawn(async move { instance.run().await }) | ||
| pub fn spawn(mut self) -> JoinHandle<()> { | ||
| tokio::spawn(async move { self.run().await }) |
There was a problem hiding this comment.
We will have to track its lifetime and restart/halt propertly.
stella3d
pushed a commit
that referenced
this pull request
Jun 7, 2022
checkpoint-consensus integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the integration of the checkpointing logic with consensus.