graphql-alt: Epoch.coinDenyList #22005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Fetch the state of `0x403` at the start of the epoch. This object can be modified during the epoch, but reads in that epoch will not be affected by writes in the same epoch, so it is always safe to treat all reads in an epoch as coming from this version of the object. ## Test plan New E2E tests: ``` sui$ cargo nextest run \ -p sui-indexer-alt-e2e-tests \ -- graphql/epochs/coin_deny_list ```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to fetch the state of the Coin DenyList object (0x403) at the start of an epoch, ensuring that reads within the epoch are consistent with the checkpoint's state. Key changes include:
- Introducing a new GraphQL field (coin_deny_list) on EpochStart to return the object state.
- Refactoring the storage of the scope by moving it from Epoch to EpochStart.
- Updating related fetch functions to use the new scope structure and SUI_DENY_LIST_OBJECT_ID.
Files not reviewed (6)
- crates/sui-indexer-alt-e2e-tests/tests/graphql/epochs/coin_deny_list.move: Language not supported
- crates/sui-indexer-alt-e2e-tests/tests/graphql/epochs/coin_deny_list.snap: Language not supported
- crates/sui-indexer-alt-graphql/schema.graphql: Language not supported
- crates/sui-indexer-alt-graphql/src/snapshots/sui_indexer_alt_graphql__tests__schema.graphql.snap: Language not supported
- crates/sui-indexer-alt-graphql/src/snapshots/sui_indexer_alt_graphql__tests__staging.graphql.snap: Language not supported
- crates/sui-indexer-alt-graphql/staging.graphql: Language not supported
7 tasks
wlmyng
reviewed
May 1, 2025
| @@ -61,6 +61,12 @@ type Epoch { | |||
| """ | |||
| epochId: UInt53! | |||
| """ | |||
| State of the Coin DenyList object (0x403) at the start of this epoch. | |||
|
|
|||
| The DenyList controls access to Regulated Coins. Writes to the DenyList are accumulated and only take effect on the next epoch boundary. Subsequently, it's possible to determine the state of the DenyList for a transaction by reading it at the start of the epoch the transaction is in. | |||
There was a problem hiding this comment.
Suggested change
| The DenyList controls access to Regulated Coins. Writes to the DenyList are accumulated and only take effect on the next epoch boundary. Subsequently, it's possible to determine the state of the DenyList for a transaction by reading it at the start of the epoch the transaction is in. | |
| The DenyList controls access to Regulated Coins. Writes to the DenyList are accumulated and only take effect on the next epoch boundary. Consequently, it's possible to determine the state of the DenyList for a transaction by reading it at the start of the epoch the transaction is in. |
|
|
||
| pub(crate) struct Epoch { | ||
| pub(crate) epoch_id: u64, | ||
| pub(crate) scope: Scope, |
There was a problem hiding this comment.
Now that I'm revisiting this, why not have
Epoch {
epoch_id
scope
}
fn start -> EpochStart::fetch
fn end -> EpochEnd::fetch
Not sure if we need the EpochStart because it's basically the scope and epoch_id before fetching contents, and the contents from db are only used on EpochStart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch the state of
0x403at the start of the epoch. This object can be modified during the epoch, but reads in that epoch will not be affected by writes in the same epoch, so it is always safe to treat all reads in an epoch as coming from this version of the object.Test plan
New E2E tests:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.