[TypeScript SDK] Fix balance field #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
commented
May 17, 2022
| @@ -14,11 +16,11 @@ export class Coin { | |||
| return getMoveObjectType(data)?.startsWith('0x2::Coin::Coin') ?? false; | |||
| } | |||
|
|
|||
| static getBalance(data: GetObjectInfoResponse): string | undefined { | |||
| static getBalance(data: GetObjectInfoResponse): BN | undefined { | |||
There was a problem hiding this comment.
balance can be u64(e.g. faucet) while JS only supports up to 53 bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some change on the Rust side in #1971 that's not reflected on the SDK side
