[explorer] Adds Search Filter #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick comment: is there a regression in the padding for "search by ID" or are you in a really old branch? Below is what's in production
|
lint changes
|
Added a small PR that changes the placeholder text for address and transaction categories, as shown here. Also adds a TS type for defining the correct strings for categories
|
stella3d
approved these changes
May 13, 2022
|
Please make sure fixing the padding issue before merging(see comment above) |
666lcz
reviewed
May 13, 2022
| case 'addresses': | ||
| return 'Search by address'; | ||
| case 'transactions': | ||
| return 'Search by digest'; |
There was a problem hiding this comment.
Suggested change
| return 'Search by digest'; | |
| return 'Search by transaction id'; |
Even though "digest" is technically more accurate, we use TxnId everywhere else, so let's be consistent here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1871 through the use of a dropdown box. The UI has been optimised bearing in mind screens even as small as the Galaxy Fold.