Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts sdk] replace WaitForLocalExecution with waitForTransaction #18929

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

hayes-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@hayes-mysten hayes-mysten requested a review from a team as a code owner August 8, 2024 13:37
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 1:41pm
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 1:41pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 1:41pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 1:41pm

Copy link
Member

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@hayes-mysten hayes-mysten merged commit a3e32fe into main Aug 13, 2024
49 of 51 checks passed
@hayes-mysten hayes-mysten deleted the mh--handle-wait-for-local-exectution-in-client branch August 13, 2024 18:26
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

Describe the changes or additions included in this PR.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants