Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactoring][wallet cli] - Wallet command refactoring #1882

Merged
merged 2 commits into from
May 19, 2022
Merged

[refactoring][wallet cli] - Wallet command refactoring #1882

merged 2 commits into from
May 19, 2022

Conversation

patrickkuo
Copy link
Contributor

@patrickkuo patrickkuo commented May 10, 2022 •
edited
Loading

make WalletCommand::execute use self instead of &mut self and removed unnecessary cloning

@patrickkuo patrickkuo changed the title [wallet cli] - Wallet command refactoring [refactoring][wallet cli] - Wallet command refactoring May 10, 2022
Base automatically changed from pat/move_coin_selection_to_gateway_and_refactoring to main May 11, 2022 14:57
@patrickkuo patrickkuo force-pushed the pat/wallet_command_refactoring branch from 32774ab to aeb9516 Compare May 17, 2022 09:16
@patrickkuo patrickkuo marked this pull request as ready for review May 17, 2022 09:46
@patrickkuo patrickkuo force-pushed the pat/wallet_command_refactoring branch from aeb9516 to ef2dc08 Compare May 18, 2022 10:00
huitseeker
huitseeker approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Thanks!

@patrickkuo patrickkuo merged commit 50da6e9 into main May 19, 2022
@patrickkuo patrickkuo deleted the pat/wallet_command_refactoring branch May 19, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@666lcz 666lcz Awaiting requested review from 666lcz

@oxade oxade Awaiting requested review from oxade

@lxfind lxfind Awaiting requested review from lxfind

@arun-koshy arun-koshy Awaiting requested review from arun-koshy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickkuo @huitseeker