Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript SDK] Fix lint warnings #1864

Merged
merged 1 commit into from
May 9, 2022
Merged

[TypeScript SDK] Fix lint warnings #1864

merged 1 commit into from
May 9, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented May 9, 2022

This PR reduces 1120 problems -> 6 problems.

Before

➜ yarn lint
1120 problems (1116 errors, 4 warnings)
  1113 errors and 0 warnings potentially fixable with the `--fix` option.

After

➜ yarn lint
yarn run v1.22.17
$ tsdx lint
Defaulting to "tsdx lint src test"
You can override this in the package.json scripts, like "lint": "tsdx lint src otherDir"

/Users/cl/ml/fastnft/sdk/typescript/src/bcs/index.ts
  741:43  warning  Expected '===' and instead saw '=='                          eqeqeq
  757:22  warning  Unexpected control character(s) in regular expression: \x00  no-control-regex

/Users/cl/ml/fastnft/sdk/typescript/src/index.ts
  23:11  error  Parsing error: 'from' expected  prettier/prettier

/Users/cl/ml/fastnft/sdk/typescript/src/types/framework/transformer.ts
  132:26  warning  Expected '!==' and instead saw '!='  eqeqeq

/Users/cl/ml/fastnft/sdk/typescript/src/types/objects.ts
  0:0  error  Parsing error: Cannot read properties of undefined (reading 'map')

/Users/cl/ml/fastnft/sdk/typescript/src/types/transactions.ts
  0:0  error  Parsing error: Cannot read properties of undefined (reading 'map')

✖ 6 problems (3 errors, 3 warnings)

I will handle the rest of the warnings as a follow up #1863

@666lcz 666lcz changed the title [TypeScript SDK] Update package publishing settings [TypeScript SDK] Fix lint warnings May 9, 2022
@@ -0,0 +1,2 @@
src/index.guard.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore because these are codegen

Base automatically changed from chris-publish to main May 9, 2022 04:43
@666lcz 666lcz requested a review from Clay-Mysten as a code owner May 9, 2022 04:43
@666lcz 666lcz merged commit 767faf1 into main May 9, 2022
@666lcz 666lcz deleted the chris-lint-ts branch May 9, 2022 05:58
longbowlu pushed a commit that referenced this pull request May 12, 2022
punwai pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants