Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #1777

Merged
merged 1 commit into from
May 4, 2022
Merged

Remove dead code #1777

merged 1 commit into from
May 4, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented May 4, 2022 •
edited
Loading

Removing some unused code. These are replaced by the more succinct transformer.ts now

@666lcz 666lcz requested a review from stella3d May 4, 2022 08:09
gdanezis
gdanezis approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love deleting code! :)

@apburnie
Copy link
Contributor

apburnie commented May 4, 2022

No problem with the removal of dead code.

@666lcz 666lcz merged commit 75a59cd into main May 4, 2022
@666lcz 666lcz deleted the sdk-dead branch May 4, 2022 18:17
longbowlu pushed a commit that referenced this pull request May 12, 2022
@666lcz @longbowlu
Remove dead code (#1777)
8dce682
punwai pushed a commit that referenced this pull request Jul 27, 2022
@666lcz @longbowlu
Remove dead code (#1777)
02ebf49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdanezis gdanezis gdanezis approved these changes

@stella3d stella3d Awaiting requested review from stella3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@666lcz @apburnie @gdanezis