Check for missing object result in search #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2022 16:14
Jibz1
approved these changes
May 3, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
* check return value of object query * lint changes
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
* check return value of object query * lint changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the query for object info doesn't find an object, the Promise doesn't reject, but returns with an
ObjectNotExistsInfo. this adds a type check, so wethrowwhen an object isn't found.This should resolve the way the
Promise.anycall works below, and thus this issue with being routed to the object error page: #1746Now, you'll be routed to the
/missing/page properly, like this: