[explorer] Render example nft #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
force-pushed
the
chris/sdk-object-fix
branch
from
4c98a0b to
703022a
Compare
666lcz
commented
May 1, 2022
| @@ -495,7 +495,7 @@ impl WalletCommands { | |||
| &Identifier::new("mint").unwrap(), | |||
| &[], | |||
| gas, | |||
| &gas_budget.unwrap_or(1000), | |||
| &gas_budget.unwrap_or(3000), | |||
There was a problem hiding this comment.
increase default budget to accommodate longer urls.
Jibz1
approved these changes
May 2, 2022
666lcz
commented
May 2, 2022
| @@ -47,7 +47,7 @@ export type GasCostSummary = { | |||
|
|
|||
| export type ExecutionStatus = | |||
| | { Success: { gas_cost: GasCostSummary } } | |||
| | { Failure: { gas_cost: GasCostSummary; error: string } }; | |||
| | { Failure: { gas_cost: GasCostSummary; error: any } }; | |||
There was a problem hiding this comment.
@Jibz1 You will see a console error from the sdk in the main branch in the landing page. This PR will fix that.
666lcz
commented
May 2, 2022
| @@ -11,7 +11,7 @@ export type AddressOwner = { AddressOwner: AddressBytes }; | |||
| export type AnyVec = { vec: any[] }; | |||
| export type JsonBytes = { bytes: number[] }; | |||
|
|
|||
| const useLocal = true; | |||
| const useLocal = false; | |||
There was a problem hiding this comment.
We should add a yarn command to control this
todd-mystenlabs
pushed a commit
that referenced
this pull request
May 2, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render the NFT created by the CLI correctly.
NOTE:
This PR only aims to make sure the data flow is correct. I will leave the UI layout improvement to @Andrew47 or @Jibz1 in separate PRs