Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] - fix in progress epoch logic #10922

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

mamos-mysten
Copy link
Contributor

@mamos-mysten mamos-mysten commented Apr 14, 2023

Description

Changes the logic for determining whether or not an Epoch is in progress as we can't rely on endOfEpochInfo to be populated, even when an epoch has ended.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 5:49am
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 5:49am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 15, 2023 5:49am
wallet-adapter ⬜️ Ignored (Inspect) Apr 15, 2023 5:49am

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mamos-mysten mamos-mysten force-pushed the mamos--fix_in_progress_epoch_logic branch from 9b77f90 to a02a04c Compare April 15, 2023 05:48
@vercel vercel bot temporarily deployed to Preview – explorer-storybook April 15, 2023 05:49 Inactive
@mamos-mysten mamos-mysten merged commit 64c4e41 into main Apr 15, 2023
@mamos-mysten mamos-mysten deleted the mamos--fix_in_progress_epoch_logic branch April 15, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants