AuthorityTemporaryStore potential inconsistent access of object state

[lxfind]

In AuthorityTemporaryStore, we have two fields that contain object state: objects and written. objects contains the original content of the objects from the input, while written contains any mutated object state.
Whenever we are trying to read objects, unless it's read-only, we will need to read from written first to see if it's there.
We should also consider renaming objects to something like original_objects to avoid confusions.

[awelc]

I will try fixing as part of #90 as (I believe) that's where the bug manifests itself.

[gdanezis]

This is a known issue, because I do not believe the VM issues reads commands for anything besides already published read-only objects. In fact why not simply remove the read operation and replace it with something like get module by ID. Or are we actually reading after writing (I do not think so, but better check).

[lxfind]

#90 will start doing reading after writing.

[gdanezis]

Ok, then temp authority needs to be more sophisticated:

• When we do a read we need to check if it has been written before.
• Depending on the needs we may need to explicitly also track deletes, since reading something after its deleted should return None or something.

[gdanezis]

Hey @awelc , has this been addressed in:

• [FastX adapter/verifier] Implement Move module initializers #337

[awelc]

This has been addressed in #337 and #436.