Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MystenLabs/sui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 151c22df38bb70d4abe8b5a2a70ede3de9797463
Choose a base ref
...
head repository: MystenLabs/sui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2ea1e941c6eef3ee23a231a58407abcbff5bdb05
Choose a head ref
  • 4 commits
  • 6 files changed
  • 2 contributors

Commits on Jul 7, 2023

  1. Fix comment about protocol config versions (#12885) 

    ## Description 

As titled, things got out of sync

## Test Plan 

This is it

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
    @dariorussi
    dariorussi authored Jul 7, 2023
    3 Configuration menu
    Copy the full SHA
    a89035b View commit details
    Browse the repository at this point in the history

  2. [sui-execution] Re-implement wrapper script in Python 

    Replace the bash script with an equivalent python script.  This is to
prepare for a couple of improvements:

- Automating the creation of the new modules in `sui-execution`, and
  the `executor` and `verifier` dispatch functions.
- Adding `rebase` and `merge` commands to simplify keeping up with
  other changes in the execution layer.

Test Plan:

```
sui$ black scripts/execution-layer
sui$ flake8 scripts/execution-layer
sui$ ./scripts/execution-layer --dry-run cut v1
sui$ ./scripts/execution-layer cut v1
```
    @amnn
    amnn committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1134c39 View commit details
    Browse the repository at this point in the history

  3. fixup: Add .py extension to script -- break the illusion of polish.

    @amnn
    amnn committed Jul 7, 2023
    1 Configuration menu
    Copy the full SHA
    b5fbe87 View commit details
    Browse the repository at this point in the history

  4. [sui-execution] Fully automate making a cut 

    Subsume the manual portion of making a cut (creating implementations
of the `Executor` and `Verifier` traits, and hooking them into the
dispatch module) into the script:

Test Plan:

```
sui$ ./scripts/execution-layer cut v1
sui-execution$ cargo build
```

Also stress test by making 10 cuts, running a clean build and an
incremental build to make sure there isn't a measurable effect on
builds (there is not).
    @amnn
    amnn committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2ea1e94 View commit details
    Browse the repository at this point in the history
Loading