[sui replay] migrate off using sui_getLoadedChildObjects json rpc api (#18213)

The PR removes usage of the sui_getLoadedChildObjects API for the remote
mode of the replay tool.
It's required to drop the corresponding index from index_db.

The change is verified by deploying the dynamic field smart contract to
devnet, modifying the underlying child object several times, and
replaying the corresponding transactions.

Author: phoenix-o

crates/sui-replay/src/data_fetcher.rs

@@ -30,7 +30,6 @@ use sui_types::object::Object;
 use sui_types::transaction::SenderSignedData;
 use sui_types::transaction::TransactionDataAPI;
 use sui_types::transaction::{EndOfEpochTransactionKind, TransactionKind};
-use tracing::error;
 
 /// This trait defines the interfaces for fetching data from some local or remote store
 #[async_trait]
@@ -85,6 +84,12 @@ pub(crate) trait DataFetcher {
     ) -> Result<Vec<SuiEvent>, ReplayEngineError>;
 
     async fn get_chain_id(&self) -> Result<String, ReplayEngineError>;
+
+    async fn get_child_object(
+        &self,
+        object_id: &ObjectID,
+        version_upper_bound: VersionNumber,
+    ) -> Result<Object, ReplayEngineError>;
 }
 
 #[derive(Clone)]
@@ -223,6 +228,16 @@ impl DataFetcher for Fetchers {
             Fetchers::NodeStateDump(q) => q.get_chain_id().await,
         }
     }
+    async fn get_child_object(
+        &self,
+        object_id: &ObjectID,
+        version_upper_bound: VersionNumber,
+    ) -> Result<Object, ReplayEngineError> {
+        match self {
+            Fetchers::Remote(q) => q.get_child_object(object_id, version_upper_bound).await,
+            Fetchers::NodeStateDump(q) => q.get_child_object(object_id, version_upper_bound).await,
+        }
+    }
 }
 
 const VERSIONED_OBJECT_CACHE_CAPACITY: Option<NonZeroUsize> = NonZeroUsize::new(1_000);
@@ -378,6 +393,20 @@ impl DataFetcher for RemoteFetcher {
             })
     }
 
+    async fn get_child_object(
+        &self,
+        object_id: &ObjectID,
+        version_upper_bound: VersionNumber,
+    ) -> Result<Object, ReplayEngineError> {
+        let response = self
+            .rpc_client
+            .read_api()
+            .try_get_object_before_version(*object_id, version_upper_bound)
+            .await
+            .map_err(|q| ReplayEngineError::SuiRpcError { err: q.to_string() })?;
+        convert_past_obj_response(response)
+    }
+
     async fn multi_get_latest(
         &self,
         objects: &[ObjectID],
@@ -441,29 +470,9 @@ impl DataFetcher for RemoteFetcher {
 
     async fn get_loaded_child_objects(
         &self,
-        tx_digest: &TransactionDigest,
+        _: &TransactionDigest,
     ) -> Result<Vec<(ObjectID, SequenceNumber)>, ReplayEngineError> {
-        let loaded_child_objs = match self
-            .rpc_client
-            .read_api()
-            .get_loaded_child_objects(*tx_digest)
-            .await
-        {
-            Ok(objs) => objs,
-            Err(e) => {
-                error!("Error getting dynamic fields loaded objects: {}. This RPC server might not support this feature yet", e);
-                return Err(ReplayEngineError::UnableToGetDynamicFieldLoadedObjects {
-                    rpc_err: e.to_string(),
-                });
-            }
-        };
-
-        // Fetch the refs
-        Ok(loaded_child_objs
-            .loaded_child_objects
-            .iter()
-            .map(|obj| (obj.object_id(), obj.sequence_number()))
-            .collect::<Vec<_>>())
+        Ok(vec![])
     }
 
     async fn get_latest_checkpoint_sequence_number(&self) -> Result<u64, ReplayEngineError> {
@@ -806,4 +815,12 @@ impl DataFetcher for NodeStateDumpFetcher {
     async fn get_chain_id(&self) -> Result<String, ReplayEngineError> {
         unimplemented!("get_chain_id for state dump is not implemented")
     }
+
+    async fn get_child_object(
+        &self,
+        _object_id: &ObjectID,
+        _version_upper_bound: VersionNumber,
+    ) -> Result<Object, ReplayEngineError> {
+        unimplemented!("get child object is not implemented for state dump");
+    }
 }

crates/sui-replay/src/lib.rs

@@ -90,8 +90,6 @@ pub enum ReplayToolCommand {
         tx_digest: String,
         #[arg(long, short)]
         show_effects: bool,
-        #[arg(long, short)]
-        diag: bool,
         /// Optional version of the executor to use, if not specified defaults to the one originally used for the transaction.
         #[arg(long, short, allow_hyphen_values = true)]
         executor_version: Option<i64>,
@@ -206,11 +204,8 @@ pub async fn execute_replay_command(
             let contents = std::fs::read_to_string(path)?;
             let sandbox_state: ExecutionSandboxState = serde_json::from_str(&contents)?;
             info!("Executing tx: {}", sandbox_state.transaction_info.tx_digest);
-            let sandbox_state = LocalExec::certificate_execute_with_sandbox_state(
-                &sandbox_state,
-                &sandbox_state.pre_exec_diag,
-            )
-            .await?;
+            let sandbox_state =
+                LocalExec::certificate_execute_with_sandbox_state(&sandbox_state).await?;
             sandbox_state.check_effects()?;
             info!("Execution finished successfully. Local and on-chain effects match.");
             None
@@ -330,12 +325,10 @@ pub async fn execute_replay_command(
                     let contents = std::fs::read_to_string(file).unwrap();
                     let sandbox_state: ExecutionSandboxState =
                         serde_json::from_str(&contents).unwrap();
-                    let sandbox_state = LocalExec::certificate_execute_with_sandbox_state(
-                        &sandbox_state,
-                        &sandbox_state.pre_exec_diag,
-                    )
-                    .await
-                    .unwrap();
+                    let sandbox_state =
+                        LocalExec::certificate_execute_with_sandbox_state(&sandbox_state)
+                            .await
+                            .unwrap();
                     sandbox_state.check_effects().unwrap();
                 }
             });
@@ -372,7 +365,6 @@ pub async fn execute_replay_command(
         ReplayToolCommand::ReplayTransaction {
             tx_digest,
             show_effects,
-            diag,
             executor_version,
             protocol_version,
         } => {
@@ -389,9 +381,6 @@ pub async fn execute_replay_command(
             )
             .await?;
 
-            if diag {
-                println!("{:#?}", sandbox_state.pre_exec_diag);
-            }
             if show_effects {
                 println!("{}", sandbox_state.local_exec_effects);
             }