Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version of psalm.phar #1007

Open
JakeQZ opened this issue Apr 13, 2021 · 1 comment
Open

Wrong version of psalm.phar #1007

JakeQZ opened this issue Apr 13, 2021 · 1 comment
Labels
Milestone

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Apr 13, 2021

php "./tools/psalm" -v

gives

Psalm 4.x-dev@

But if Psalm is installed with Composer by adding the following to composer.json

"vimeo/psalm": "^4.7.0"

then

php "./vendor/bin/psalm" -v

gives

Psalm 4.7.0@d4377c0baf3ffbf0b1ec6998e8d1be2a40971005

Also, without Psalm installed with Composer, I get 29 additional errors reported when running composer ci:php:psalm. But if it is installed with Composer, even if run via the .phar, it runs as expected. Psalm bootstraps via Composer, and its classes will be autoloaded from the Composer-installed version, if available, in preference to those in the .phar.

I don't know why this problem is not being seen on the build server, or @oliverklee you are not seeing a problem either. Could it be autoloading classes from elsewhere on the system?

@JakeQZ JakeQZ added the bug label Apr 13, 2021
@JakeQZ JakeQZ added this to the 6.0.0 milestone Apr 13, 2021
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 13, 2021

The version we have matches the one at https://github.com/vimeo/psalm/releases/download/4.7.0/psalm.phar and I also find the same issue with 4.6.4.

@oliverklee oliverklee modified the milestones: 6.0.0, 7.0.0 Sep 14, 2021
@oliverklee oliverklee modified the milestones: 7.0.0, 8.0.0 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants