[TASK] Add interface RuleContainer for RuleSet
#1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
added
the
refactor
This covers the maniplation of `Rule`s within the container, and may be implemented by other classes in future (e.g. #1194). Note that the naming is consistent with the current codebase, rather than what the CSS entities are now called: - `Rule` represents what is now called a "declaration"; - `RuleSet` represents what is now called a "declaration block"; - `DeclarationBlock` represents what is now called a "style rule"; - `CSSListItem` (closely) represents what is now generically called a "rule". Renaming things is part of a longer-term plan touched on in #1189.
JakeQZ
force-pushed
the
task/rulecontainer-interface
branch
from
ffa66d9 to
6c4065b
Compare
oliverklee
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the maniplation of
Rules within the container, and may be implemented by other classes in future (e.g. #1194).Note that the naming is consistent with the current codebase, rather than what the CSS entities are now called:
Rulerepresents what is now called a "declaration";RuleSetrepresents what is now called a "declaration block";DeclarationBlockrepresents what is now called a "style rule";CSSListItem(closely) represents what is now generically called a "rule".Renaming things is part of a longer-term plan touched on in #1189.