Skip to content

[TASK] Deconflate getAllValues() parameters #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2025
Merged

[TASK] Deconflate getAllValues() parameters #1242

merged 6 commits into from
Apr 12, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Apr 11, 2025

This is the backport of #1231, #1240 and #1241.

cf. #1230

@JakeQZ JakeQZ added cleanup testing PRs/issues adding additional tests only, or primarily testing-focused deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality backport labels Apr 11, 2025
@JakeQZ JakeQZ self-assigned this Apr 11, 2025
@JakeQZ JakeQZ marked this pull request as draft April 11, 2025 23:12
@JakeQZ JakeQZ force-pushed the backport/getallvalues branch from 8b7a2b8 to 4a5e284 Compare April 11, 2025 23:17
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Apr 11, 2025

Note that the first commit applies only #1231. A further commit will fix errors with older PHP versions. Then #1240 and #1241 will be merged in turn, probably with an additional commit for each to deal with older PHP versions.

@JakeQZ JakeQZ force-pushed the backport/getallvalues branch 2 times, most recently from 2fd3d35 to 8e34424 Compare April 11, 2025 23:39
@JakeQZ JakeQZ force-pushed the backport/getallvalues branch from 8e34424 to 82cf934 Compare April 11, 2025 23:43
@JakeQZ JakeQZ force-pushed the backport/getallvalues branch 2 times, most recently from 5fcbe87 to 28dda3d Compare April 12, 2025 00:28
@JakeQZ JakeQZ force-pushed the backport/getallvalues branch from 28dda3d to 836b5b6 Compare April 12, 2025 00:34
@JakeQZ JakeQZ force-pushed the backport/getallvalues branch from 594b640 to 8d192a6 Compare April 12, 2025 00:46
@JakeQZ JakeQZ marked this pull request as ready for review April 12, 2025 00:51
@JakeQZ JakeQZ requested a review from oliverklee April 12, 2025 00:51
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Apr 12, 2025

Reviewing may be easier by viewing each commit separately. Maybe that backport should have been separate PRs, but as the changes have already been approved on main, I don't see much value in that, given the steps taken can still be seen individually by viewing the separate commits.

@JakeQZ JakeQZ mentioned this pull request Apr 12, 2025
Merged
@oliverklee oliverklee merged commit f5fc39a into v8.x Apr 12, 2025
22 checks passed
@oliverklee oliverklee deleted the backport/getallvalues branch April 12, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
backport cleanup deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeQZ @oliverklee