Skip to content

[CLEANUP] Remove CSSBlockList::allDeclarationBlocks() #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[CLEANUP] Remove CSSBlockList::allDeclarationBlocks() #1239

merged 1 commit into from
Apr 9, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 9, 2025

Change the one remaining usage instance to use getAllDeclarationBlocks(), which was refactored in #990.

Part of #994.

@JakeQZ
[CLEANUP] Remove CSSBlockList::allDeclarationBlocks()
7dcc6d2 
Change the one remaining usage instance to use `getAllDeclarationBlocks()`,
which was refactored in #990.

Part of #994.
@JakeQZ JakeQZ added cleanup refactor For PRs that refactor code without changing functionality labels Apr 9, 2025
@JakeQZ JakeQZ requested a review from oliverklee April 9, 2025 21:50
@JakeQZ JakeQZ self-assigned this Apr 9, 2025
@coveralls
Copy link

Coverage Status

coverage: 54.658% (+0.3%) from 54.382%
when pulling 7dcc6d2 on cleanup/remove-alldeclarationblocks
into f036005 on main.

@oliverklee oliverklee merged commit 0c94d6e into main Apr 9, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/remove-alldeclarationblocks branch April 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup refactor For PRs that refactor code without changing functionality
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee