Skip to content

[BUGFIX] Correct AtRuleBlockListTest::implementsAtRule() #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[BUGFIX] Correct AtRuleBlockListTest::implementsAtRule() #1238

merged 1 commit into from
Apr 9, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 8, 2025

Use the interface type to be tested for in the assertion, not the type of the object itself.

@JakeQZ
[BUGFIX] Correct AtRuleBlockListTest::implementsAtRule()
59739e5 
Use the interface type to be tested for in the assertion,
not the type of the object itself.
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Apr 8, 2025
@JakeQZ JakeQZ requested a review from oliverklee April 8, 2025 23:48
@JakeQZ JakeQZ self-assigned this Apr 8, 2025
@coveralls
Copy link

Coverage Status

coverage: 53.315%. remained the same
when pulling 59739e5 on bugfix/test/implements-at-rule
into 4e107ac on main.

@oliverklee oliverklee merged commit 3ab40c6 into main Apr 9, 2025
21 checks passed
@oliverklee oliverklee deleted the bugfix/test/implements-at-rule branch April 9, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee