Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline account functionality to use with Quill #4281

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Mrtenz
Copy link
Collaborator

@Mrtenz Mrtenz commented Feb 16, 2022

This PR adds a new account type called "Offline account", which can be used together with Quill to sign transactions offline.

@Mrtenz Mrtenz temporarily deployed to STAGING February 16, 2022 15:25 Inactive
@Mrtenz Mrtenz temporarily deployed to STAGING February 16, 2022 15:28 Inactive
@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #4281 (542bc2e) into master (144b8aa) will increase coverage by 0.08%.
The diff coverage is 85.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
+ Coverage   78.73%   78.82%   +0.08%     
==========================================
  Files         572      576       +4     
  Lines       12429    12498      +69     
  Branches     3068     3085      +17     
==========================================
+ Hits         9786     9851      +65     
- Misses       2611     2615       +4     
  Partials       32       32              
Impacted Files Coverage Δ
src/components/BusyBottom/constants.ts 100.00% <ø> (ø)
src/components/SignTransactionWallets/index.ts 100.00% <ø> (ø)
src/config/wallets.ts 100.00% <ø> (ø)
src/features/AddAccount/AddAccountForm.reducer.tsx 15.00% <0.00%> (-0.39%) ⬇️
src/features/AddAccount/stories.tsx 100.00% <ø> (ø)
src/features/BroadcastTransaction/helpers.ts 0.00% <0.00%> (ø)
src/index.tsx 0.00% <ø> (ø)
...es/BroadcastTransaction/components/BroadcastTx.tsx 89.28% <72.22%> (-5.96%) ⬇️
src/components/SignTransactionWallets/Offline.tsx 100.00% <100.00%> (ø)
src/components/WalletUnlock/Offline.tsx 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144b8aa...542bc2e. Read the comment docs.

@Mrtenz Mrtenz temporarily deployed to STAGING February 17, 2022 14:07 Inactive
@Mrtenz Mrtenz temporarily deployed to STAGING February 22, 2022 09:36 Inactive
@Mrtenz Mrtenz temporarily deployed to STAGING February 22, 2022 12:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants