service start dnsmasq always return true

[mirasrael]

In dnsmasq.sh script used command service dnsmasq start || service dnsmasq restart which never restarts server because first part always returns true.
It may be rewritten as:
(service dnsmasq status && service dnsmasq restart) || service dnsmasq start

My configuration:
OS:

NAME="Ubuntu"
VERSION="14.04.3 LTS, Trusty Tahr"
ID=ubuntu

Dnsmasq version 2.68

[johnweldon]

I don't think this is true; while testing this I found that service dnsmasq start returns 1 instead of 0 when dnsmasq is already running. (Additionally, these scripts are copied directly from the upstream hashicorp/c1m repo)

How are you reproducing the behaviour you describe?

[mirasrael]

Hi @johnweldon.

> docker run --privileged -it --rm ubuntu:trusty
root@228c2b6db12f:/# apt-get update && apt-get instal -y dnsmasq
root@228c2b6db12f:/# service dnsmasq start
 * Starting DNS forwarder and DHCP server dnsmasq                                                                                                                                                                                        [ OK ] 
root@228c2b6db12f:/# service dnsmasq start || echo 1
 * Starting DNS forwarder and DHCP server dnsmasq
 * (already running)

As you can see no "1" printed here.

[johnweldon]

Ah, interesting... this is different if you don't use the --privileged flag to docker... in that case you have to modify the dnsmasq.conf file to allow it to start (set user=root), and then the behaviour is different:

root@d27bebcf7201:/# vi /etc/dnsmasq.conf 
root@d27bebcf7201:/# service dnsmasq start || echo 1
 * Starting DNS forwarder and DHCP server dnsmasq                        [ OK ] 
root@d27bebcf7201:/# service dnsmasq start || echo 1
 * Starting DNS forwarder and DHCP server dnsmasq                               
dnsmasq: failed to create listening socket for port 53: Address already in use
                                                                         [fail]
1
root@d27bebcf7201:/# 

Are you seeing this problem in the actual GCE images? I'll do some more experimentation to see if it actually occurs there (i.e. if those images run with the --privileged flag).. if so we'll open a PR upstream to the hashicorp/c1m repo too.

[mirasrael]

I initially found this issue when installing it on my Virtualbox VM (under vagrant user). So it is not related to --privileged mode only.