fix(input): unmount race condition

Author: MunifTanjim

lua/nui/input/init.lua

@@ -128,6 +128,12 @@ function Input:unmount()
 
   Input.super.unmount(self)
 
+  if self._.loading then
+    return
+  end
+
+  self._.loading = true
+
   local pending_submit_value = self._.pending_submit_value
 
   vim.schedule(function()
@@ -147,6 +153,7 @@ function Input:unmount()
     else
       self._.on_close()
     end
+    self._.loading = false
   end)
 end
 

tests/nui/input/init_spec.lua

@@ -99,6 +99,25 @@ describe("nui.input", function()
 
       eq(done, true)
     end)
+
+    it("is called on unmount", function()
+      local done = false
+
+      input = Input(popup_options, {
+        on_close = function()
+          done = true
+        end,
+      })
+
+      input:mount()
+      input:unmount()
+
+      vim.fn.wait(200, function()
+        return done
+      end)
+
+      eq(done, true)
+    end)
   end)
 
   describe("cursor_position_patch", function()
@@ -210,4 +229,27 @@ describe("nui.input", function()
       eq(vim.api.nvim_win_get_cursor(parent_winid), initial_cursor)
     end)
   end)
+
+  describe("method :unmount", function()
+    it("is idempotent", function()
+      local done = 0
+
+      input = Input(popup_options, {
+        on_close = function()
+          done = done + 1
+        end,
+      })
+
+      input:mount()
+      input:unmount()
+      input:unmount()
+      input:unmount()
+
+      vim.fn.wait(200, function()
+        return done > 1
+      end)
+
+      eq(done, 1)
+    end)
+  end)
 end)