Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support for Staticman nested comments #197

Closed
VincentTam opened this issue Nov 24, 2018 · 5 comments
Closed

[Question] Support for Staticman nested comments #197

VincentTam opened this issue Nov 24, 2018 · 5 comments

Comments

@VincentTam
Copy link

VincentTam commented Nov 24, 2018

Hi, this is the author of halogenica/beautifulhugo#222.

Anyone using this theme would like to have support for nested comments?

Staticman nested reply demo
My Staticman demo site on GitLab: https://vincenttam.gitlab.io/bhdemo served by @staticmanlab.

Background [TL;DR]

Observing that the nested comments implemented on Network Hobo (Staticman's README "Useful links") contains a logic error, I've published the linked PR.

staticman nested comments logic error
Everyone replies to the same person? (Dan replies to Dan?)

@MunifTanjim
Copy link
Owner

What's this about? 😕

@VincentTam
Copy link
Author

Comment with reply support.

@MunifTanjim
Copy link
Owner

MunifTanjim commented Nov 24, 2018

For what? This theme already has nested Staticman comment support.

And this is not a place for polls.

@VincentTam
Copy link
Author

I didn't see that from this theme's README and demo. Sorry about that.

I suppose GitHub issues is a place for discussion about a project, such as eduardoboucas/staticman#22.

@MunifTanjim
Copy link
Owner

MunifTanjim commented Nov 24, 2018

It's okay. I appreciate your interest. Don't be sorry. 🙂

Well, it really depends on the maintainers of specific projects, how they utilize the issues section on Github.

By the way, tagging unrelated issues only creates unwanted noise (on the tagged issue). Please don't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants