Skip to content

Commit 997881d

Browse files
committed
PTHMINT-81: Change the tax_rate_percentage to integer
1 parent 26cb336 commit 997881d

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

src/multisafepay/api/shared/cart/cart_item.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def add_weight(self: "CartItem", weight: Weight) -> "CartItem":
248248

249249
def add_tax_rate_percentage(
250250
self: "CartItem",
251-
tax_rate_percentage: float,
251+
tax_rate_percentage: int,
252252
) -> "CartItem":
253253
"""
254254
Add tax rate percentage to the cart item.
@@ -261,7 +261,7 @@ def add_tax_rate_percentage(
261261
262262
Parameters
263263
----------
264-
tax_rate_percentage: (float) The tax rate percentage to be added.
264+
tax_rate_percentage: (int) The tax rate percentage to be added.
265265
266266
Returns
267267
-------
@@ -279,7 +279,8 @@ def add_tax_rate_percentage(
279279
)
280280

281281
try:
282-
self.tax_table_selector = str(tax_rate_percentage / 100)
282+
rating = tax_rate_percentage / 100
283+
self.tax_table_selector = str(rating)
283284
except (ValueError, TypeError) as e:
284285
raise InvalidArgumentException(
285286
"Tax rate percentage cannot be converted to a string.",

tests/multisafepay/unit/api/shared/cart/test_unit_cart_item.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,5 +231,25 @@ def test_add_tax_rate_percentage():
231231
232232
"""
233233
item = CartItem()
234-
item.add_tax_rate_percentage(21.0)
234+
item.add_tax_rate_percentage(21)
235235
assert item.tax_table_selector == "0.21"
236+
237+
238+
def test_add_tax_rate_percentage():
239+
"""
240+
Test that a 0 tax rate percentage is correctly set as the tax table selector in a CartItem.
241+
242+
"""
243+
item = CartItem()
244+
item.add_tax_rate_percentage(0)
245+
assert item.tax_table_selector == "0.0"
246+
247+
248+
def test_add_tax_rate_percentage():
249+
"""
250+
Test that a 0.0 tax rate percentage is correctly set as the tax table selector in a CartItem.
251+
252+
"""
253+
item = CartItem()
254+
item.add_tax_rate_percentage(0.0)
255+
assert item.tax_table_selector == "0.0"

0 commit comments

Comments
 (0)